Bug 468602

Summary:	Latest update of the Android app prevents desktop app from ever synchronizing SMS
Product:	[Applications] kdeconnect	Reporter:	Cip <ciprian.m.vizitiu>
Component:	messaging-application	Assignee:	Simon Redman <simon>
Status:	RESOLVED FIXED
Severity:	major
Priority:	NOR
Version First Reported In:	22.12.3
Target Milestone:	---
Platform:	Android
OS:	Unspecified
Latest Commit:		Version Fixed/Implemented In:	1.24.1
Sentry Crash Report:

Description Cip 2023-04-17 09:32:59 UTC

SUMMARY
Following the update to version 1.24 (from F-Droid), the desktop app will no longer sync messages. 


STEPS TO REPRODUCE
1.  Update to version 1.24 when prompted by F-Droid app
2.  Bring up the KDE connect SMS window, notice the spinner. 
3.  Confirm by unlocking the phone that we do have a connection to the desktop computer
3.  Wait for messages to show-up nothing happens. 
4.  Press "Refresh" and wait for another hour or two. 

OBSERVED RESULT

No SMS are ever displayed in the desktop appplication.

EXPECTED RESULT

KDE connect should have displayed the SMS conversations listing. 

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 37;
KDE Plasma Version: None running, XFCE 4.16 
KDE Frameworks Version:  5.104.0
Qt Version: Qt 5.15.8

ADDITIONAL INFORMATION

Galaxy XCover Pro 6; Android 13 Kernel 5,4,147. 

Notifications about new SMS messages still appear on the desktop plus sending files works so the connection is definitely active. More to the point, it worked with the previous version of the Android app. Apart from the usual problems (phone becoming unavailable for absolutely no reason and having to reach for it and unlock) the combo worked. The desktop app would take between three to ten seconds to re-sync once the phone was back in the network but that was it.

Comment 1 Simon Redman 2023-04-17 12:11:38 UTC

This is presumably due to the change from if/else to switch here, which forgot breaks between the cases: https://invent.kde.org/network/kdeconnect-android/-/commit/038f6e8598441103f0bf3c95b55a759d56534df8#3f11df9dbfb12205751132bb9f36348782af1924

It is fixed here: https://invent.kde.org/network/kdeconnect-android/-/merge_requests/337/diffs

Which is part of the 1.24.1 release from this weekend. I've asked for that to be pushed to F-Droid.

Comment 2 Simon Redman 2023-04-18 11:32:39 UTC

Version 1.24.1 is available on the F-Droid store

Comment 3 Cip 2023-04-18 11:45:29 UTC

... and fix confirmed to be working. Thank you very much Simon.