Bug 468556

Summary: Build failure for vgdb
Product: [Developer tools] valgrind Reporter: Paul Floyd <pjfloyd>
Component: generalAssignee: Julian Seward <jseward>
Status: RESOLVED FIXED    
Severity: normal CC: mark
Priority: NOR    
Version First Reported In: 3.21 GIT   
Target Milestone: ---   
Platform: Other   
OS: Solaris   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Paul Floyd 2023-04-16 07:43:40 UTC 
Here is the build log.

It probably needs something like pipe + fcntl F_DUPFD_CLOEXEC

gcc -std=gnu11 -m64 -O2 -g -Wall -Wmissing-prototypes -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-declarations -Wcast-align -Wcast-qual -Wwrite-strings -Wempty-body -Wformat -Wformat-security -Wignored-qualifiers -Wmissing-parameter-type -Wlogical-op -Wold-style-declaration -finline-functions -fno-stack-protector -fno-strict-aliasing -fno-builtin   -fomit-frame-pointer    -m64 -O2 -g -Wall -Wmissing-prototypes -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-declarations -Wcast-align -Wcast-qual -Wwrite-strings -Wempty-body -Wformat -Wformat-security -Wignored-qualifiers -Wmissing-parameter-type -Wlogical-op -Wold-style-declaration -finline-functions -fno-stack-protector -fno-strict-aliasing -fno-builtin   -fomit-frame-pointer    -Wl,-M,/usr/lib/ld/map.noexstk  -o valgrind valgrind-launcher-linux.o valgrind-m_debuglog.o  
gcc -std=gnu11 -m64 -O2 -g -Wall -Wmissing-prototypes -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-declarations -Wcast-align -Wcast-qual -Wwrite-strings -Wempty-body -Wformat -Wformat-security -Wignored-qualifiers -Wmissing-parameter-type -Wlogical-op -Wold-style-declaration -finline-functions -fno-stack-protector -fno-strict-aliasing -fno-builtin   -fomit-frame-pointer    -m64 -O2 -g -Wall -Wmissing-prototypes -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-declarations -Wcast-align -Wcast-qual -Wwrite-strings -Wempty-body -Wformat -Wformat-security -Wignored-qualifiers -Wmissing-parameter-type -Wlogical-op -Wold-style-declaration -finline-functions -fno-stack-protector -fno-strict-aliasing -fno-builtin   -fomit-frame-pointer    -o vgdb vgdb-vgdb.o    vgdb-vgdb-invoker-solaris.o  -lsocket 
Undefined			first referenced
 symbol  			    in file
pipe2                               vgdb-vgdb.o
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
gmake[3]: *** [vgdb] Error 1
gmake[3]: *** Waiting for unfinished jobs....
mv -f m_replacemalloc/.deps/libreplacemalloc_toolpreload_x86_solaris_a-vg_replace_malloc.Tpo m_replacemalloc/.deps/libreplacemalloc_toolpreload_x86_solaris_a-vg_replace_malloc.Po
mv -f m_syswrap/.deps/libcoregrind_x86_solaris_a-syswrap-generic.Tpo m_syswrap/.deps/libcoregrind_x86_solaris_a-syswrap-generic.Po
mv -f m_syswrap/.deps/libcoregrind_x86_solaris_a-syswrap-solaris.Tpo m_syswrap/.deps/libcoregrind_x86_solaris_a-syswrap-solaris.Po
gmake[3]: Leaving directory `/export/home/paulf/test321/valgrind-3.21.0.RC1/coregrind'
gmake[2]: *** [all] Error 2
gmake[2]: Leaving directory `/export/home/paulf/test321/valgrind-3.21.0.RC1/coregrind'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/export/home/paulf/test321/valgrind-3.21.0.RC1'
gmake: *** [all] Error 2
Comment 1 Mark Wielaard 2023-04-16 11:20:58 UTC 
Sigh, Solaris only got pipe2 in 11.4.

I tried to fix it with:

commit 932332e660a458e51068937130d557fb4acc6630
Author: Mark Wielaard <mark@klomp.org>
Date:   Sun Apr 16 13:15:03 2023 +0200

    Use pipe in vgdb if system doesn't have pipe2
    
    Add a configure check for pipe2. If it isn't available use pipe
    and fcntl F_SETFD FD_CLOEXEC in vgdb.c.
    
    https://bugs.kde.org/show_bug.cgi?id=468556

But don't have access to a Solaris setup