| Summary: | Be smarter about finding the app icon like Plasmashell does for apps that set their desktop files incorrectly | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Wyatt Childers <kdebugs.81do7> |
| Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | bugseforuns, kdedev, miren_radia, nate, nicolas.fella |
| Priority: | NOR | ||
| Version First Reported In: | 5.27.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Wyatt Childers
2023-04-03 20:05:48 UTC
On Wayland, these are unfortunately application bugs. You'll need to report them to the apps themselves. (In reply to Nate Graham from comment #1) > On Wayland, these are unfortunately application bugs. You'll need to report > them to the apps themselves. Perhaps this is an ideological stance on the Kwin side, but it seems quite contrary to what seems like "common sense" (i.e., that if Plasma can figure out the application icon, Kwin could figure out the icon)? The issue is that KWin is a window manager and gets its window icons from the window. So the window has to *have* an icon for KWin to display. The Task Manager, on the other hand looks in the app's desktop file to get the icon. KWin theoretically could do this too, so you're not wrong that it's an ideological stance on the part of the KWin developers. The thing is, always using the .desktop file icon would mean that if the window did set its own icon, KWin would discard it, ignoring the wishes of the developer. KWin could do it only when the window doesn't set its own window icon, maybe. But this could seem random to the user. (In reply to Nate Graham from comment #3) > The issue is that KWin is a window manager and gets its window icons from > the window. So the window has to *have* an icon for KWin to display. The > Task Manager, on the other hand looks in the app's desktop file to get the > icon. KWin theoretically could do this too, so you're not wrong that it's an > ideological stance on the part of the KWin developers. The thing is, always > using the .desktop file icon would mean that if the window did set its own > icon, KWin would discard it, ignoring the wishes of the developer. KWin > could do it only when the window doesn't set its own window icon, maybe. But > this could seem random to the user. I think it would be completely sensible to fallback to the desktop file when the application has not set an icon. If a window sets an icon that's great, and sure it should be used. However, if a window fails to set an icon, I think it's far more shocking that a "wayland" or "x11" icon is used, meanwhile KDE (as a whole) clearly sees a much more optimal answer provided by the desktop file. i.e., I'd argue the rule should be: 1. Use what the window set 2. Use what the desktop set 3. Use a fallback icon for Wayland/X11 (as a last resort) #2 is always going to be far more user relevant than #3. In terms of UX, I think the most compelling use case is that, as it stands, if this bug is exhibited by a handful of currently open applications the icon only task switcher is rendered borderline useless. Yes, that seems reasonable to me. Nate, I'm afraid you are mistaken. On Wayland there is no concept of a window icon. The icon you see for Wayland apps *always* comes from the desktop file. Now why are some icons missing? This happens when the desktop file name reported by the app doesn't match the actual desktop file on disk. Plasma has some extra code that tries to fix up these broken apps that kwin doesn't have, which is why some apps have icons in Plasma but not in KWin (In reply to Nicolas Fella from comment #6) > Nate, I'm afraid you are mistaken. > > On Wayland there is no concept of a window icon. The icon you see for > Wayland apps *always* comes from the desktop file. Now why are some icons > missing? This happens when the desktop file name reported by the app doesn't > match the actual desktop file on disk. Plasma has some extra code that tries > to fix up these broken apps that kwin doesn't have, which is why some apps > have icons in Plasma but not in KWin Perhaps that logic could be moved into one of the KDE frameworks, and then shared between Plasma and Kwin so things are always consistent? Urp, my bad. I'll try to remember that. Indeed, moving that logic to a central place so KWin can use it too seems like a good idea. Moving so the kwin developers can consider this |