| Summary: | Calculator memory leak | ||
|---|---|---|---|
| Product: | [Plasma] krunner | Reporter: | Yeshi <nikolai.bjerke.sakariassen2> |
| Component: | calculator | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | alexander.lohnau, nate, qydwhotmail |
| Priority: | NOR | ||
| Version: | 5.27.3 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/207e3e330505829604da07f5593a16135e2019b1 | Version Fixed In: | 5.27.5 |
| Sentry Crash Report: | |||
|
Description
Yeshi
2023-04-02 16:47:44 UTC
Please report the bug to libqalculate (In reply to Fushan Wen from comment #1) > Please report the bug to libqalculate I believe a timeout after a few seconds would go a long way here. Perhaps even setting a memory limit could work. Both of these solutions should be better than having plasmashell restart. (In reply to Yeshi from comment #2) > (In reply to Fushan Wen from comment #1) > > Please report the bug to libqalculate > > I believe a timeout after a few seconds would go a long way here. > Perhaps even setting a memory limit could work. > > Both of these solutions should be better than having plasmashell restart. Forgot to mention, I have reported this bug to libqalculate. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2799 Git commit 3f3bea079bb55ec70ce248d1238cd0e7e38e5261 by Fushan Wen. Committed on 08/04/2023 at 07:17. Pushed by fusionfuture into branch 'Plasma/5.27'. runners/calculator: set timeout to prevent allocating huge memory This is not exactly a memory leak. The extreme expression simply requires huge amounts of memory to calculate. The calculator runner is problematic since it does not specify a time limit for calculations, and does not even abort calculations after the window has been closed (a simple example of this is the expression 123456789!). Fixes https://github.com/Qalculate/libqalculate/issues/527 FIXED-IN: 5.27.5 M +7 -2 runners/calculator/qalculate_engine.cpp https://invent.kde.org/plasma/plasma-workspace/commit/3f3bea079bb55ec70ce248d1238cd0e7e38e5261 Git commit 207e3e330505829604da07f5593a16135e2019b1 by Fushan Wen. Committed on 08/04/2023 at 07:41. Pushed by fusionfuture into branch 'master'. runners/calculator: set timeout to prevent allocating huge memory This is not exactly a memory leak. The extreme expression simply requires huge amounts of memory to calculate. The calculator runner is problematic since it does not specify a time limit for calculations, and does not even abort calculations after the window has been closed (a simple example of this is the expression 123456789!). Fixes https://github.com/Qalculate/libqalculate/issues/527 FIXED-IN: 5.27.5 (cherry picked from commit 3f3bea079bb55ec70ce248d1238cd0e7e38e5261) M +7 -2 runners/calculator/qalculate_engine.cpp https://invent.kde.org/plasma/plasma-workspace/commit/207e3e330505829604da07f5593a16135e2019b1 |