Bug 467736

Summary: Image Quality Sort ignores disabled "Assign Pick Labels"
Product: [Applications] digikam Reporter: michael2macdonald
Component: Tags-QualityAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 7.9.0   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 8.0.0
Sentry Crash Report:

Description michael2macdonald 2023-03-24 00:37:25 UTC
SUMMARY
Image Quality Sort ignores disabled "Assign Pick Labels". It always adds all three Pick Labels to images, even if you disabled some of the labels under  "Assign 'xxx' Label to xxx Quality Pictures".

STEPS TO REPRODUCE
1. Select Images
2. Open Quality Sort
3. Disable one or two of the "Assign 'xxx' Label to xxx Quality Pictures" options
4. Run Image Quality Sort

OBSERVED RESULT
All images are labeled and all three Pick Labels are used (Including the ones that were disabled)

EXPECTED RESULT
Only the enabled Pick Labels should be added to images

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.27.3
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
This happens on both version 7.9.0 RPMs, version 7.10.0 appimages, and version 8.0.0 appimages. All were tested on KDE Fedora.
Comment 1 Maik Qualmann 2023-03-24 07:10:30 UTC
Git commit f8cc5106f10ebed60117df2ce0011a2f6a7a0d5f by Maik Qualmann.
Committed on 24/03/2023 at 07:09.
Pushed by mqualmann into branch 'master'.

fix disabled pick labels in the Image Quality Sorter
FIXED-IN: 8.0.0

M  +1    -1    NEWS
M  +31   -13   core/libs/imgqsort/imagequalityparser.cpp

https://invent.kde.org/graphics/digikam/commit/f8cc5106f10ebed60117df2ce0011a2f6a7a0d5f