Bug 467416

Summary: IOTM does not center properly between two spacers on a vertical panel
Product: [Plasma] plasmashell Reporter: Vojtěch Bartoň <gamingforyou875>
Component: Task Manager and Icons-Only Task ManagerAssignee: veggero <niccolo.venerandi>
Status: RESOLVED FIXED    
Severity: normal CC: bizyaev, nate, niccolo.venerandi
Priority: NOR    
Version: 5.27.2   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.27.5
Attachments: Bug in action

Description Vojtěch Bartoň 2023-03-15 19:59:11 UTC
Created attachment 157317 [details]
Bug in action

SUMMARY
While having the "Fill empty space" option checked, the Task Manager on a vertical panel seems to have a set minimum height that makes spacers not work properly. Once this minimum height is exceeded, spacers start to work properly. Horizontal panels do not seem to be affected by this bug.

STEPS TO REPRODUCE
1. Add a VERTICAL panel with an Icon-Only Task Manager between two spacers
2. Uncheck the "Fill empty space" option in it's settings

OBSERVED RESULT
Task Manager is off-center.

EXPECTED RESULT
Center the Task Manager properly.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 37
(available in About System)
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Comment 1 Nate Graham 2023-03-15 20:42:16 UTC
It also seems like that empty space should be added on the other side.

Does it work better if you make your panel horizontal?

Is the Task Manager a "Task Manager" or an "Icons-Only Task Manager"?
Comment 2 Vojtěch Bartoň 2023-03-15 20:56:40 UTC
(In reply to Nate Graham from comment #1)
> It also seems like that empty space should be added on the other side.
> 
> Does it work better if you make your panel horizontal?
> 
> Is the Task Manager a "Task Manager" or an "Icons-Only Task Manager"?

Hi, It's the Icons-Only Task Manager. About the empty space, I don't think there should be any in the first place, it's preventing the spacers from centering the Task Manager. This only affects vertical panels, horizontal ones center just fine.

This bug report is also a follow up to the bug I submitted a couple hours ago: https://bugs.kde.org/show_bug.cgi?id=467385
Comment 3 Nate Graham 2023-03-15 20:59:36 UTC
I can also reproduce that. It centers problem in my horizontal panel, but not my vertical panel.
Comment 4 Nate Graham 2023-03-26 00:31:59 UTC
Centers *properly*!
Comment 5 Nate Graham 2023-03-26 00:32:49 UTC
Any ideas, Niccolò?
Comment 6 Bug Janitor Service 2023-04-08 14:57:51 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2807
Comment 7 Nate Graham 2023-04-08 16:18:32 UTC
Git commit db0ab0e4fe1c0b5971a8164ba0083d329a09b0e3 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 08/04/2023 at 16:18.
Pushed by ngraham into branch 'master'.

applets/panelspacer: Use height values for vertical panel in spacers

Otherwise centering applets doesn't work properly for vertical panels.
FIXED-IN: 5.27.5

M  +3    -2    applets/panelspacer/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/db0ab0e4fe1c0b5971a8164ba0083d329a09b0e3
Comment 8 Nate Graham 2023-04-08 16:19:23 UTC
Git commit c88d93ce9019ba47a5591c3bc44caef9973b3088 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 08/04/2023 at 16:19.
Pushed by ngraham into branch 'Plasma/5.27'.

applets/panelspacer: Use height values for vertical panel in spacers

Otherwise centering applets doesn't work properly for vertical panels.
FIXED-IN: 5.27.5


(cherry picked from commit db0ab0e4fe1c0b5971a8164ba0083d329a09b0e3)

M  +3    -2    applets/panelspacer/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/c88d93ce9019ba47a5591c3bc44caef9973b3088
Comment 9 Nate Graham 2023-04-10 02:40:47 UTC
*** Bug 468275 has been marked as a duplicate of this bug. ***