| Summary: | 5e702ee5d70b9f54fbe02ffe43c5d8409424c6fc regresses rectangular region positioning in viewer window | ||
|---|---|---|---|
| Product: | [Applications] Spectacle | Reporter: | Nate Graham <nate> |
| Component: | General | Assignee: | Boudhayan Gupta <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, noahadvs |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | git-master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/spectacle/commit/cd9db55c57c4dea398dce2341d78ab2197a140fc | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Quarter-size screenshot | ||
Can confirm this happens at 200% scale, not just on wayland either A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/212 Git commit 659ca669db4711d553ddee0c9c4d78bafc3496ad by Noah Davis. Committed on 15/03/2023 at 15:02. Pushed by ndavis into branch 'master'. AnnotationDocument: Divide image size by devicePixelRatio in addImage() M +1 -1 src/Gui/Annotations/AnnotationDocument.cpp https://invent.kde.org/graphics/spectacle/commit/659ca669db4711d553ddee0c9c4d78bafc3496ad Git commit cd9db55c57c4dea398dce2341d78ab2197a140fc by Noah Davis. Committed on 15/03/2023 at 15:04. Pushed by ndavis into branch 'release/23.04'. AnnotationDocument: Divide image size by devicePixelRatio in addImage() (cherry picked from commit 659ca669db4711d553ddee0c9c4d78bafc3496ad) M +1 -1 src/Gui/Annotations/AnnotationDocument.cpp https://invent.kde.org/graphics/spectacle/commit/cd9db55c57c4dea398dce2341d78ab2197a140fc |
Created attachment 157306 [details] Quarter-size screenshot I'm using Wayland with 200% scale. With that commit, rectangular region screenshots are mis-positioned in the viewer window; instead of being either maximized in the window (if they would need to be scaled down) or centered in it (if they fully fit), they are now always displayed at 50% size in the top-left corner. See attached screenshot. To reproduce the issue: 1. Use Wayland 2. Use 200% scale 3. Launch Spectacle and take a Rectangular region screenshot This worked as expected in 7378735a6cbd4c3d02f23f02e88b9452ee0e54ab.