Bug 467352

Summary: When playlist is cleared, reset slider position to 0
Product: [Applications] Elisa Reporter: Emir SARI <emir_sari>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: minor CC: nate
Priority: NOR    
Version: 22.12.3   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 23.04

Description Emir SARI 2023-03-14 17:39:08 UTC
When a song is paused, and I gave up listening to that song, there is no way to reset the progress bar and the other relevant states. A "Stop" button is expected to clean the application state.

When the red X is clicked on the playlist, the progress bar does not reset either.
Comment 1 Nate Graham 2023-03-15 17:09:37 UTC
This is somewhat deliberate, so minimize the number of unnecessary buttons in the UI.

Can you explain exactly why you want this button? Can you pause the song and go play another one? Doesn't that do the same thing?
Comment 2 Emir SARI 2023-03-15 17:25:02 UTC
Well, I guess it’s a bit psychological though; you just want the software to reset to its initial state. I am okay with not having one, but even when the playlist is empty, the progress bar is still busy, and it gives a bad look. Maybe correcting that is enough.
Comment 3 Nate Graham 2023-03-15 17:27:40 UTC
Sure, that seems reasonable.
Comment 4 Nate Graham 2023-03-15 21:20:43 UTC
Git commit e59197b3daf5abe2559d5054e6c5b5b7cc823912 by Nate Graham.
Committed on 15/03/2023 at 21:18.
Pushed by ngraham into branch 'master'.

Reset slider position to 0 when manually clearing playlist

Otherwise the slider gets disabled, but not reset, so it's stuck in a
nonzero position until you play some more music. This isn't really a
problem per se, but it looks kind of weird.
FIXED-IN: 23.04

M  +7    -0    src/qml/DurationSlider.qml

https://invent.kde.org/multimedia/elisa/commit/e59197b3daf5abe2559d5054e6c5b5b7cc823912
Comment 5 Nate Graham 2023-03-15 21:21:16 UTC
Git commit 8219a57e1b9196a437a235d7c6d43c24cbdfdd17 by Nate Graham.
Committed on 15/03/2023 at 21:20.
Pushed by ngraham into branch 'release/23.04'.

Reset slider position to 0 when manually clearing playlist

Otherwise the slider gets disabled, but not reset, so it's stuck in a
nonzero position until you play some more music. This isn't really a
problem per se, but it looks kind of weird.
FIXED-IN: 23.04
(cherry picked from commit e59197b3daf5abe2559d5054e6c5b5b7cc823912)

M  +7    -0    src/qml/DurationSlider.qml

https://invent.kde.org/multimedia/elisa/commit/8219a57e1b9196a437a235d7c6d43c24cbdfdd17
Comment 6 Emir SARI 2023-03-16 09:23:27 UTC
Thank you!
Comment 7 Nate Graham 2023-03-16 15:01:02 UTC
You're welcome!