| Summary: | Elisa does not recognise covers with .jpeg extension | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Emir SARI <emir_sari> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jackhill3103, nate |
| Priority: | NOR | ||
| Version First Reported In: | 22.12.3 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/elisa/-/commit/07af3b8db46008bb3c0e99dfc3013b2364a0dc8e | Version Fixed/Implemented In: | 23.08 |
| Sentry Crash Report: | |||
|
Description
Emir SARI
2023-03-13 11:23:18 UTC
What's the exact filename that doesn't work? And what exactly do you change it to to make it work? It’s a standard ASCII file name only with the extension .jpeg. When I rename the extension to .jpg and rebuild the database, Elisa recognises the cover and displays it on the main window. That's odd because the code definitely explicitly supports both .jpg and .jpeg as file extensions: https://invent.kde.org/multimedia/elisa/-/blob/master/src/filescanner.cpp#L74 Can you provide the full filename anyway? My bad, I just realised that there is a Unicode Middle Dot on the artist name: Sak·Sok - The First Lession of Tatar.jpg Thanks. Can you try setting the indexer to Scan The Filesystem Directly and then scanning for new music? Might be an issue with Baloo Sorry, I am far away from this machine at this moment. I only have a VM available with no personal data at all, so it will be a while until I get back to this. No worries, I realised that Elisa does not check for "jpeg" extensions when searching for images that share the same name as the directory. Will be fixed shortly Git commit 07af3b8db46008bb3c0e99dfc3013b2364a0dc8e by Nate Graham, on behalf of Jack Hill. Committed on 27/06/2023 at 19:38. Pushed by ngraham into branch 'master'. Build cover file search strings from file name + extension So if we choose to support a new extension for cover files, we only need to add it in one location rather than multiple places. Also, the search for cover files that matched the name of the directory did not include files with "jpeg" extensions. This is now fixed. M +29 -20 src/filescanner.cpp https://invent.kde.org/multimedia/elisa/-/commit/07af3b8db46008bb3c0e99dfc3013b2364a0dc8e |