Bug 467056

Summary: Fallback theme's icons-only buttons lack tooltips
Product: [Plasma] kscreenlocker Reporter: David <david.cortes.rivera>
Component: generalAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: minor CC: nate
Priority: NOR Keywords: usability
Version: 5.27.2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kscreenlocker/-/commit/549dc0d8574822a5b0bdbdffdf8cd716970d005c Version Fixed In: 6.0
Sentry Crash Report:
Attachments: kde_lock_screen_strange_button
kde_sddm_is_breeze

Description David 2023-03-08 15:27:12 UTC 
SUMMARY
The new redesigned lock screen has two buttons, but it doesn't tell me what the one at the right is for when I hover the mouse. If I click it, it takes me to the old lock screen style, but entering my password there simply displays the KDE spash screen and doesn't log in, unless I manually switch TTYs back and forth which gets me to the new login screen where I can now click the first button instead of the second.

STEPS TO REPRODUCE
1. Press Windows+L; or run krunner and select "Lock".
2. Start typing.
3. Notice that there's two buttons to the left of the password bar, but if I hover the mouse, it doesn't tell me what each one does and the icon for the one on the right doesn't resemble anything I'm familiar with.
4. Click the button to the right.
5. Put your user password in the new screen (which is the old lock screen style).

OBSERVED RESULT
Displays the splash screen with the plasma engine continuously running, but doesn't log in.

EXPECTED RESULT
No idea, but it should make it clear to me before I click it as a hover pop-up.

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux 12
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.1.0-6-amd64 (64-bit)
Graphics Platform: X11
Processors: 20 × 12th Gen Intel® Core™ i7-12700H
Memory: 62.5 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Manufacturer: SLIMBOOK
Product Name: Executive
ADDITIONAL INFORMATION
Comment 1 Nate Graham 2023-03-13 17:40:43 UTC 
Hmm, in the Breeze lock screen design, there are no icons to the left of the password field. Please attach a screenshot that shows the issue.
Comment 2 David 2023-03-13 17:44:12 UTC 
Created attachment 157237 [details]
kde_lock_screen_strange_button

Attached a screenshot of the new button on the new lock screen.
Comment 3 Nate Graham 2023-03-13 17:56:25 UTC 
That's not the Breeze lock screen. :) This is actually the fallback theme in case your lock screen theme is broken. Apparently it is!

The button means "switch user" and clicking on it takes you to the SDDM login screen, which apparently is not broken. I can see from the code that the button doesn't have a tooltip; we should definitely add one.
Comment 4 David 2023-03-13 18:39:59 UTC 
Created attachment 157239 [details]
kde_sddm_is_breeze

But I have my settings configured to use the default breeze theme, just without the picture. Moreover, it does display the breeze theme if I click that button to change user.
Comment 5 Nate Graham 2023-03-13 19:19:17 UTC 
That screenshot depicts the page in System settings for configuring the appearance of the *login* screen, not the *lock* screen. Your *lock* screen is broken; your *login* screen is working fine. They're not the same thing. Clicking on the "switch user" button on the *lock* screen (either a working theme or the fallback theme) will take you to the *login* screen, which is where user switching is implemented.
Comment 6 Nate Graham 2023-07-31 14:57:26 UTC 
Git commit 549dc0d8574822a5b0bdbdffdf8cd716970d005c by Nate Graham.
Committed on 31/07/2023 at 16:57.
Pushed by ngraham into branch 'master'.

Fix and modernize fallback theme

The fallback theme was using PlasmaComponents 2 and wasn't working at
all in Plasma 6.

This commits ports it to modern components so that it works again, and
gets rid of some unnecessary old code and old QML paradigms in the
process.
FIXED-IN: 6.0

To test, break your lock screen theme and lock the screen. You should see the fallback theme now:

| Greeter | Session switcher |
| ------- | ---------------- |
| ![greeter](/uploads/6bc3471eb93b63f3ced68bd1369ddec3/greeter.jpg) | ![session_switcher](/uploads/6d00d2e413f01073b2854b2d3f99fa1b/session_switcher.jpg) |

@davidedmundson @mart @davidre

M  +0    -1    greeter/fallbacktheme.qrc
D  +0    -33   greeter/fallbacktheme/AccelButton.qml
M  +54   -78   greeter/fallbacktheme/Greeter.qml
M  +25   -16   greeter/fallbacktheme/LockScreen.qml
M  +91   -107  greeter/fallbacktheme/SessionSwitching.qml

https://invent.kde.org/plasma/kscreenlocker/-/commit/549dc0d8574822a5b0bdbdffdf8cd716970d005c