Bug 467035

Summary:	Transform tools are broken in the Krita Next nightly
Product:	[Applications] krita	Reporter:	Tyson Tan <tysontanx>
Component:	Tools/Transform	Assignee:	amyspark <amy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ghevan
Priority:	NOR
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/b628f31ae02ddf899bb8271a40f42804699ab366	Version Fixed/Implemented In:
Sentry Crash Report:

Description Tyson Tan 2023-03-08 01:44:40 UTC

Transform tools in the latest Krita Next nightly has broken. They show a busy icon when activated, no handle is displayed, nothing can be transformed. I can still switch back to other tools using keyboard shortcuts.

Tested on:
krita-5.2.0-prealpha-8d720211e2-x86_64.appimage (2023-03-08)

It was still working on:
krita-5.2.0-prealpha-486d154afc-x86_64.appimage (2023-03-07)

Comment 1 vanyossi 2023-03-08 01:47:39 UTC

Yeah I get this exact same behaviour, reverting 8d720211e2 fixes it. Ill assign amyspark to it

Comment 2 amyspark 2023-03-24 18:16:44 UTC

Git commit b628f31ae02ddf899bb8271a40f42804699ab366 by L. E. Segovia.
Committed on 08/03/2023 at 12:10.
Pushed by lsegovia into branch 'master'.

Revert "TransformStrokeStrategy: pass references instead of ~512B of state"

This reverts commit 8d720211e292c2c3e8afb242593eff16b60aaee5.

M  +3    -11   plugins/tools/tool_transform2/kis_tool_transform.cc
M  +1    -3    plugins/tools/tool_transform2/kis_tool_transform.h
M  +2    -2    plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp
M  +1    -1    plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.h
M  +1    -1    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
M  +1    -1    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h

https://invent.kde.org/graphics/krita/commit/b628f31ae02ddf899bb8271a40f42804699ab366