Summary: | List of keyboard layouts in SDDM theme is hard to scroll with a pointing device and impossible to scroll with a touchscreen | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Marc Deop <kde> |
Component: | Theme - Breeze | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, visual-design |
Priority: | NOR | Keywords: | accessibility, usability |
Version: | 5.27.2 | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/plasma-framework/commit/a8f127192a94e1effbd2f2366f3bfd77f53333e8 | Version Fixed In: | 5.104 |
Sentry Crash Report: | |||
Attachments: | layouts_list |
Description
Marc Deop
2023-03-06 20:10:06 UTC
Hmm, it shouldn't need to be scrolled in the first place. Can you attach a screenshot of that it looks like when it's in this state? Created attachment 157090 [details]
layouts_list
Got it. Can confirm. It's even annoying with a pointing device. This menu is provided by PlasmaComponents3.Menu, which appears to not respond properly to either a scroll action or a touchscreen flick/swipe, at least in this context. The code largely looks set up for it. Maybe there's a weird bug in it... I see the problem: interactive: ApplicationWindow.window ? contentHeight > ApplicationWindow.window.height : false In the SDDM login screen, ApplicationWindow.window is null, so we fall back to false. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/754 Git commit e4830f160bcec9e30f6181c75dead7817020d874 by Nate Graham. Committed on 08/03/2023 at 17:24. Pushed by ngraham into branch 'master'. PC3 menu: make interactive condition more robust If the menu has a content height that exceeds the available height, but ApplicationWindow.window isn't set--for example because we're in the SDDM login screen where there is no application window--then we'll hit the fallback condition and be non-interactive, which makes the menu terribly difficult to scroll with a pointing device and impossible to scroll with a touchscreen. To fix this, consult Window.window rather than ApplicationWindow.window. This is what other styles do. FIXED-IN: 5.105 M +2 -1 src/declarativeimports/plasmacomponents3/Menu.qml https://invent.kde.org/frameworks/plasma-framework/commit/e4830f160bcec9e30f6181c75dead7817020d874 Git commit a8f127192a94e1effbd2f2366f3bfd77f53333e8 by Nate Graham. Committed on 08/03/2023 at 17:31. Pushed by ngraham into branch 'kf5'. PC3 menu: make interactive condition more robust If the menu has a content height that exceeds the available height, but ApplicationWindow.window isn't set--for example because we're in the SDDM login screen where there is no application window--then we'll hit the fallback condition and be non-interactive, which makes the menu terribly difficult to scroll with a pointing device and impossible to scroll with a touchscreen. To fix this, consult Window.window rather than ApplicationWindow.window. This is what other styles do. FIXED-IN: 5.105 (cherry picked from commit e4830f160bcec9e30f6181c75dead7817020d874) M +2 -1 src/declarativeimports/plasmacomponents3/Menu.qml https://invent.kde.org/frameworks/plasma-framework/commit/a8f127192a94e1effbd2f2366f3bfd77f53333e8 |