Bug 466938

Summary:	Duplicate Detection Reference Image
Product:	[Applications] digikam	Reporter:	Ron <ronaday>
Component:	Searches-Similarity	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, martin.marmsoler, metzpinguin
Priority:	NOR
Version First Reported In:	8.0.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/fecc957fda73704b05c425dbacaa47a42319228c	Version Fixed/Implemented In:	8.2.0
Sentry Crash Report:

Description Ron 2023-03-06 12:11:07 UTC

SUMMARY
When searching for duplicates lower resolution images are often selected as reference images.  Not related to the date of the image, it can be newer or older, doesn't seem to matter.  Sometimes they are in the same album, sometimes not. From the forums it seems we ALL want the highest resolution, highest quality image to be "reference".   What is the point of the "remove dupes" button if it's going to delete some of the highest quality images?  Useless.

STEPS TO REPRODUCE
1. Detect duplicates
2. Scroll through results until you find a reference image that is lower quality than the "dupe".
3. 

OBSERVED RESULT
There will be several cases where the lowest quality image has been selected as the reference image in error. 

EXPECTED RESULT
It is expected that all reference images are the highest quality in each set of "dupes".  

SOFTWARE/OS VERSIONS
Windows:  11
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
This same behavior is present on Ubuntu also.

Comment 1 Maik Qualmann 2023-03-06 14:02:17 UTC

Is it really digiKam-8.0.0, is it correct? It is valid for older versions, but not for 8.0.0. Not only the date is used to determine the original image, but also the file size and image size. I've tested it with many sample images and the "better" image is always set as the reference image.

Maik

Comment 2 Maik Qualmann 2023-03-06 20:19:13 UTC

Git commit fecc957fda73704b05c425dbacaa47a42319228c by Maik Qualmann.
Committed on 06/03/2023 at 20:18.
Pushed by mqualmann into branch 'master'.

more priority on pixel and file size for reference image
FIXED-IN: 8.0.0

M  +1    -1    NEWS
M  +7    -7    core/libs/database/haar/haariface.cpp

https://invent.kde.org/graphics/digikam/commit/fecc957fda73704b05c425dbacaa47a42319228c

Comment 3 Ron 2023-03-07 02:48:17 UTC

I am running version 8.  This is ->not<- fixed! 
Why are you lieing?  Why not just admit it's not fixed?

Comment 4 caulier.gilles 2023-03-07 02:58:58 UTC

The Windows installer 8.0.0 pre-release do not integrate yet the last commit in source code from comment #2 by Maik. This will fix your problem. You needs to wait a more recent rebuild of 8.0.0 windows installer available here :

https://files.kde.org/digikam/unstable/

Gilles Caulier

Comment 5 caulier.gilles 2023-04-19 04:55:31 UTC

Hi Ron,

8.0.0 is published. This report is fixed now ?

Best regards

Gilles Caulier

Comment 6 Martin 2023-04-19 09:37:49 UTC

I can have a look into this, because I worked a few days in this area so I am familiar with the code

Comment 7 Martin 2023-04-19 09:39:56 UTC

Ron, can you give me sample images where this happens? You can also try to download some from the internet and crop them to get a simple reproducable example. So it is easier to fix the issue

Comment 8 Maik Qualmann 2023-04-19 11:04:56 UTC

I'm pretty sure the bug is fixed. I will test it again tonight with the new implementation. Ron tested a version in Comment 3 that did not yet contain the fix from Comment 2.

Maik

Comment 9 caulier.gilles 2023-05-03 13:02:27 UTC

Well... fixed or not fixed, that the Q (:=-))))...

Gilles