Bug 466835

Summary:	No way to quit Elisa from its main window anymore when "Keep running in System Tray" option is active
Product:	[Applications] Elisa	Reporter:	Nagy Tibor <xnagytibor>
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR	Keywords:	regression
Version:	22.12.2
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/elisa/commit/da97156222b5efb9302f2a7d91d2e13e0c8cb93b	Version Fixed In:	23.04

Description Nagy Tibor 2023-03-04 15:05:01 UTC

SUMMARY
Previously there was a "Quit" menu item under the hamburger menu in Elisa. This menu item was rather important, this served the purpose of quitting Elisa from its main window when having the "Keep running in System Tray" feature was active, because in this case the window close button did not close Elisa, just minimized it.

By removing this "Quit" menu item there's no way to quit Elisa from its main window anymore in this case. Would be nice having this menu item back, at least when the "Keep running in System Tray" option is active.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.27
KDE Plasma Version: 5.27.1
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Graphics Platform: X11

ADDITIONAL INFORMATION
This regression was introduced somewhere between Plasma 5.26 and 5.27.

Comment 1 Bug Janitor Service 2023-03-09 21:35:12 UTC

A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/422

Comment 2 Nate Graham 2023-03-16 15:37:27 UTC

Git commit 7e29b9d94b3181ca1d0c10800b9dfa0fbf352ad0 by Nate Graham, on behalf of Nikita Karpei.
Committed on 16/03/2023 at 15:37.
Pushed by ngraham into branch 'master'.

Add the quit action in the application menu when using tray icon feature

This lets the app actually be quit (not just its main window closed)
from the hamburger menu when using the system tray icon feature.
FIXED-IN: 23.04

M  +18   -0    src/qml/ApplicationMenu.qml

https://invent.kde.org/multimedia/elisa/commit/7e29b9d94b3181ca1d0c10800b9dfa0fbf352ad0

Comment 3 Nate Graham 2023-03-16 15:38:09 UTC

Git commit da97156222b5efb9302f2a7d91d2e13e0c8cb93b by Nate Graham, on behalf of Nikita Karpei.
Committed on 16/03/2023 at 15:37.
Pushed by ngraham into branch 'release/23.04'.

Add the quit action in the application menu when using tray icon feature

This lets the app actually be quit (not just its main window closed)
from the hamburger menu when using the system tray icon feature.
FIXED-IN: 23.04


(cherry picked from commit 7e29b9d94b3181ca1d0c10800b9dfa0fbf352ad0)

M  +18   -0    src/qml/ApplicationMenu.qml

https://invent.kde.org/multimedia/elisa/commit/da97156222b5efb9302f2a7d91d2e13e0c8cb93b