| Summary: | Digikam git can't manage 16 bit float .xcf | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kimageformats | Reporter: | maderios <leoutation> |
| Component: | general | Assignee: | Alex Merry <alex.merry> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, kdelibs-bugs, metzpinguin, mircomir |
| Priority: | NOR | ||
| Version: | 5.10.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
maderios
2023-03-04 11:32:55 UTC
The XCF image loader is part of the KImageFormats plugins, which we at digiKam do not develop. Maik Mirco you did some work on the xcf code. Would you have some time to look at this? Since we got the same bug report about supporting float16 (half float) for our TIFF loader, here maybe the function to read and convert float16 as a help. The basic function comes from the Adobe DNG-SDK. https://invent.kde.org/graphics/digikam/-/blob/master/core/dplugins/dimg/tiff/dimgtiffloader_load.cpp#L951 Maik (In reply to Albert Astals Cid from comment #2) > Mirco you did some work on the xcf code. > > Would you have some time to look at this? The Qt plugin supports xcf specs up to version 11 and the files in question are version 12. We have a merge request to add this functionality but it has other problems and consequently it breaks the tests. I tested the MR (https://invent.kde.org/frameworks/kimageformats/-/merge_requests/108) and some generated images are not correct (mainly related to alpha blending) . Adding support to version 12 requires in-depth knowledge of the XCF format which I don't have. (In reply to Maik Qualmann from comment #3) > Since we got the same bug report about supporting float16 (half float) for > our TIFF loader, here maybe the function to read and convert float16 as a > help. The basic function comes from the Adobe DNG-SDK. > > https://invent.kde.org/graphics/digikam/-/blob/master/core/dplugins/dimg/ > tiff/dimgtiffloader_load.cpp#L951 Recent Qts also have the type qfloat16 and I just used that to read TIFFs :) Thanks for pointing to qfloat16. Maik I see KImageFormats works fine with .psd proprietary Adobe format. This leads people to think that it is difficult to work professionally with free image editing software, Gimp ... (In reply to maderios from comment #7) > I see KImageFormats works fine with .psd proprietary Adobe format. Nobody has it with GIMP. The PSD plugin works well because I work in large format digital printing and everyone uses Photoshop. I maintain two PSD readers: the one for the company I work for (it's not a qt plugin) and the KDE Qt plugin (for fun). I would also like to fix the XCF plugin but no promises. For now, I've only looked at the specs. A hope that seems dead :( https://invent.kde.org/frameworks/kimageformats/-/merge_requests/108#note_693028 (In reply to maderios from comment #9) > A hope that seems dead :( > https://invent.kde.org/frameworks/kimageformats/-/merge_requests/ > 108#note_693028 I made some changes to Martin's code to fix the most obvious problems and made a new MR (https://invent.kde.org/frameworks/kimageformats/-/merge_requests/166). Please try it. I consider the problem solved. For problems with the future GIMP 3, please refer to the specific bug report (https://bugs.kde.org/show_bug.cgi?id=491795). |