Bug 466773

Summary: Conversion raw (Panasonic rw2) to DNG with bugs.
Product: [Applications] digikam Reporter: diekuhrannte <diekuhrannte>
Component: Plugin-Bqm-DngConverterAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
Latest Commit: Version Fixed In: 8.2.0
Sentry Crash Report:

Description diekuhrannte@web.de 2023-03-03 16:21:46 UTC
SUMMARY
***
Converting Panasonic ra2 to DNG is not good. digiKam makes dng that show wrong lens in RawTherapee: Olympus instead of Leica 12-60! and the embedded jpg are much darker than those in the original raw file.
***


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Linux/XFCE 

ADDITIONAL 
The DNGs that Adobe dngconverters create do not have this problem.

Here is an example:
https://filebin.net/adlep4e0u273gzy5
Comment 1 Maik Qualmann 2023-03-04 20:05:13 UTC
The lens information is missing because Exiv2 has a problem reading the Makernotes and they are not copied correctly. Unfortunately, RawTherapee does not look at the XMP metadata in which we make a copy.
The thumbnail is a libraw conversion without "optimizations".
For the Makernotes we need to use ExifTool.

Exiv2 ( 3 ) :  Offset of directory Panasonic, entry 0x8010 is out of bounds: Offset = 0x00010fa0; truncating the entry

Maik
Comment 2 diekuhrannte@web.de 2023-03-04 21:59:55 UTC
Hello Maik,
yes, the strange thing is that ART and darktable does not have these problems.
Unfortunately, I understand little of your comment: "Exiv2 ( 3 ) :  Offset of directory Panasonic, entry 0x8010 is out of bounds: Offset = 0x00010fa0; truncating the entry" ???

But let me ask if digiKam will change something there, or if everything will stay the same.

I am very interested in a good conversion to DNG. Switched from Windows to Manjaro Linux, and if I could do without Adobe DNG Converter over wine in the future, would be wonderful.

Currently digiKam also has problems with the size of the embedded Jpeg. They are mostly not made in original size but much smaller, unfortunately.

My question: What can I do to make digiKam better? I can't program, but I can do a lot of testing. Tell me what, I will do it.

Best regards from
Michael
Comment 3 Maik Qualmann 2023-03-05 08:59:02 UTC
Git commit dae53215345c0d161b9643cb77ca843ec50fd98a by Maik Qualmann.
Committed on 05/03/2023 at 08:57.
Pushed by mqualmann into branch 'master'.

use only ExifTool to copy Makernotes

M  +2    -2    core/libs/dngwriter/dngwriter_convert.cpp

https://invent.kde.org/graphics/digikam/commit/dae53215345c0d161b9643cb77ca843ec50fd98a
Comment 4 Maik Qualmann 2023-03-05 09:02:45 UTC
Git commit 509e2065c4960d140a405384bf989e7dcad82a8e by Maik Qualmann.
Committed on 05/03/2023 at 09:01.
Pushed by mqualmann into branch 'master'.

set a Stage3Gain for thumbnail and preview

M  +1    -0    core/libs/dngwriter/dngwriter_export.cpp

https://invent.kde.org/graphics/digikam/commit/509e2065c4960d140a405384bf989e7dcad82a8e
Comment 5 Maik Qualmann 2023-03-05 09:17:29 UTC
Git commit c5dc9674f7bb4d43fea03440dc61adebb980c753 by Maik Qualmann.
Committed on 05/03/2023 at 09:16.
Pushed by mqualmann into branch 'master'.

set by default full size preview image in DNG

M  +1    -1    core/dplugins/bqm/convert/converttodng/converttodng.cpp
M  +1    -1    core/dplugins/generic/tools/dngconverter/dngconverterdialog.cpp
M  +1    -1    core/dplugins/generic/tools/dngconverter/dngconvertertask.cpp
M  +1    -1    core/dplugins/generic/tools/dngconverter/dngconverterthread.cpp
M  +1    -1    core/libs/dngwriter/dngsettings.cpp
M  +1    -1    core/libs/dngwriter/dngwriter_p.cpp
M  +1    -1    core/utilities/import/backend/downloadsettings.h
M  +1    -1    core/utilities/import/widgets/dngconvertsettings.cpp

https://invent.kde.org/graphics/digikam/commit/c5dc9674f7bb4d43fea03440dc61adebb980c753
Comment 6 Maik Qualmann 2023-03-05 09:26:56 UTC
Please check this DNG file created by digiKam-8.0.0 (git/master) if all is ok.

https://drive.google.com/file/d/1hRHY1lPK-prxpRHrOSxeyo_LZtNK2Zji/view?usp=share_link

Maik
Comment 7 diekuhrannte@web.de 2023-03-05 13:34:07 UTC
Hallo Maik,

I'm thrilled: the lens is now recognized correctly in RawTherapee. How did you do that? Can digiKam do that on its own in the future?

(Do you speak German? That would be a great help for me, not having to translate everything back and forth.
I am so excited. I am dying to do something for digiKam).
Comment 8 diekuhrannte@web.de 2023-03-05 14:01:44 UTC
(In reply to Maik Qualmann from comment #6)
> Please check this DNG file created by digiKam-8.0.0 (git/master) if all is
> ok.
> 
> https://drive.google.com/file/d/1hRHY1lPK-prxpRHrOSxeyo_LZtNK2Zji/
> view?usp=share_link
> 
> Maik

I have just tested the digiKam version 8.0.0beta1: Unfortunately still the wrong lens. I will be patient until the good version is available normally.
Comment 9 Maik Qualmann 2023-03-05 14:13:33 UTC
Yes I speak German. Here, however, English is the preferred language so that all developers can understand it. But you can write in German in a private mail.

As the changes were first added to digiKam-8.0.0 today, they not yet be available in a downloaded version. Gilles will certainly build new digiKam-8.0.0 bundles again soon, which will then be available here:

https://files.kde.org/digikam/unstable/

Maik
Comment 10 diekuhrannte@web.de 2023-03-05 14:24:01 UTC
>.. Here, however, English is the preferred language so that
> all developers can understand it. But you can write in German in a private
> mail.
> Maik

I understand, here in the forum English is the correct language. So far I can already cope with it.

I am looking forward to the new version.

Question: How reliable is it to convert your raw files to dng with digiKam? Can you delete your original raw afterwards with a clear conscience?

I'm aiming for this mainly because with digiKam I can write keywords and annotations directly into the dng. That's why I'm still using the Adobe DNG Converter at the moment. If I could replace this completely with digiKam, that would be wonderful. 

And, how can I write to you privately?

Michael
Comment 11 caulier.gilles 2023-05-03 08:29:14 UTC
@diekuhrannte@web.de 

digiKam 8.0.0 is out. This entry still valid with this release ?

Best regards

Gilles Caulier
Comment 12 diekuhrannte@web.de 2023-08-01 15:06:27 UTC
The problem is solved. 
Thank you.
Comment 13 Maik Qualmann 2023-08-01 16:39:17 UTC
Thanks for the feedback.

Maik