Bug 466638

Summary: Morphing Popups effect inappropriately animates dragged-ang-dropped desktop icons under certain circumstances
Product: [Plasma] kwin Reporter: antonio <antdev66>
Component: effects-variousAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: nate, notmart
Priority: NOR    
Version: 5.27.2   
Target Milestone: ---   
Platform: Debian unstable   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=466637
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: example

Description antonio 2023-03-01 07:28:02 UTC
SUMMARY
I noticed that "Sliding Tooltips" is enabled, during the move of an object on desktop, artifacts are displayed

STEPS TO REPRODUCE
1. Enable sliding tooltips effect
2. Create a desktop element
3. Select and move it (Drag and Drop)

OBSERVED RESULT
By dragging the object, artifacts are produced

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Comment 1 antonio 2023-03-01 07:28:36 UTC
Created attachment 156851 [details]
example
Comment 2 Nate Graham 2023-04-10 00:09:31 UTC
Is "Sliding tooltips" a 3rd-party effect that you installed? I don't see anything like that installed by default on my system.
Comment 3 antonio 2023-04-10 08:19:34 UTC
(In reply to Nate Graham from comment #2)
> Is "Sliding tooltips" a 3rd-party effect that you installed? I don't see
> anything like that installed by default on my system.

This effect is installed by Debian/Sid from the package:
	pp kwin-data

the current version is:
	4:5.27.3-1

which installs the directory:
	/usr/share/kwin/effects/kwin4_effect_morphingpopups
	
in fact, by removing this directory, the effect no longer appears in the list. It is not an installation of user side but an effect managed by the package maintenance.
Comment 4 antonio 2023-04-10 08:27:34 UTC
Note that this effect is also present in the source provided by the repository:
     https://www-ftp.lip6.fr/pub/X11/kde/stable/plasma/5.27.3/kwin-5.27.3.tar.xz

drwxrwxr-x kde/kde           0 2023-03-14 13:25 kwin-5.27.3/src/effects/morphingpopups/
drwxrwxr-x kde/kde           0 2023-03-14 13:25 kwin-5.27.3/src/effects/morphingpopups/package/
drwxrwxr-x kde/kde           0 2023-03-14 13:25 kwin-5.27.3/src/effects/morphingpopups/package/contents/
drwxrwxr-x kde/kde           0 2023-03-14 13:25 kwin-5.27.3/src/effects/morphingpopups/package/contents/code/
-rw-rw-r-- kde/kde        4519 2023-03-14 13:25 kwin-5.27.3/src/effects/morphingpopups/package/contents/code/morphingpopups.js
-rw-rw-r-- kde/kde        7958 2023-03-14 13:25 kwin-5.27.3/src/effects/morphingpopups/package/metadata.jso
Comment 5 Nate Graham 2023-04-10 13:41:11 UTC
Ah, it's the "Morphing Popups" effect, which has somehow been renamed to "Sliding Popups".

Do you have any custom window rules set that could explain why the effect is inappropriately trying to animate drag-and-dropped desktop icons?
Comment 6 antonio 2023-04-10 13:51:19 UTC
(In reply to Nate Graham from comment #5)
> Ah, it's the "Morphing Popups" effect, which has somehow been renamed to
> "Sliding Popups".
> 
> Do you have any custom window rules set that could explain why the effect is
> inappropriately trying to animate drag-and-dropped desktop icons?

No windows rules are active. Even disabling all the other effects, the problem persists.
I don't see other elements that can influence this behavior.
Comment 7 Nate Graham 2023-04-10 16:34:37 UTC
Ok, thanks.
Comment 8 Bug Janitor Service 2024-06-09 05:52:23 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5861
Comment 9 David Edmundson 2024-06-11 20:08:48 UTC
Git commit d6360cc4ce4e0d85862a4bb077b8b3dc55cd74a7 by David Edmundson.
Committed on 11/06/2024 at 19:58.
Pushed by davidedmundson into branch 'master'.

effects: Drop morphing popups effect

The effect does not work very well for two main reasons:
Some clients will make a new popup rather than move an existing one, so
whether it does anything is highly unpredictable as a user.

Popups can be of massively different sizes with different amounts of
text. This means the text in the smaller popup gets resized which
doesn't look like a natural in-between state of the two popups. This
defeats the objective of looking smoother.

On top of that, it's rather glitchy.
This effect was purely visual, no functionality changes.
Related: bug 473411, bug 416048, bug 461501, bug 466637

M  +0    -1    src/plugins/CMakeLists.txt
D  +0    -1    src/plugins/morphingpopups/CMakeLists.txt
D  +0    -137  src/plugins/morphingpopups/package/contents/code/main.js
D  +0    -144  src/plugins/morphingpopups/package/metadata.json

https://invent.kde.org/plasma/kwin/-/commit/d6360cc4ce4e0d85862a4bb077b8b3dc55cd74a7