Summary: | since upgrade to KDE Framework 5.103, kstart5 does not return after starting application | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Erwan David <kde> |
Component: | general | Assignee: | thenujan <sthenujan2002> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dap78, kde, kdelibs-bugs, nate, nicolas.fella, paragoumba, sthenujan2002 |
Priority: | NOR | Keywords: | regression |
Version: | 5.103.0 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kio/commit/01481fb95ec443988dfbf51116d807359c08dfab | Version Fixed In: | 5.105 |
Description
Erwan David
2023-02-24 16:01:37 UTC
Oh dear, yeah. Because we now emitResult() only after the process has actually terminated, rather than immediately. Perhaps we can fix KStart to handle this change better? > Perhaps we can fix KStart to handle this change better?
No, we must revert to the original behavior
Ok. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/1225 Git commit fea052ba369e474a092516a4717556b52ff92e00 by Nicolas Fella, on behalf of Thenujan Sandramohan. Committed on 24/03/2023 at 22:33. Pushed by nicolasfella into branch 'kf5'. CommandLauncher: call emitResult() as soon as process has started This MR makes `emitResult` get called as soon as the process has started instead of when the process has ended. It also changes `emitDelayedError` as a protected member of `KProcessRunner` to make it invokable by `ForkingProcessRunner`. It also removes `processFinished` signal as it's not used anymore. M +0 -2 src/gui/commandlauncherjob.cpp M +1 -2 src/gui/kprocessrunner.cpp M +1 -6 src/gui/kprocessrunner_p.h https://invent.kde.org/frameworks/kio/commit/fea052ba369e474a092516a4717556b52ff92e00 Git commit 01481fb95ec443988dfbf51116d807359c08dfab by Nicolas Fella, on behalf of Thenujan Sandramohan. Committed on 24/03/2023 at 22:38. Pushed by nicolasfella into branch 'master'. CommandLauncher: call emitResult() as soon as process has started This MR makes `emitResult` get called as soon as the process has started instead of when the process has ended. It also changes `emitDelayedError` as a protected member of `KProcessRunner` to make it invokable by `ForkingProcessRunner`. It also removes `processFinished` signal as it's not used anymore. M +0 -2 src/gui/commandlauncherjob.cpp M +1 -2 src/gui/kprocessrunner.cpp M +1 -6 src/gui/kprocessrunner_p.h https://invent.kde.org/frameworks/kio/commit/01481fb95ec443988dfbf51116d807359c08dfab |