Bug 466101

Summary:	Konsole: Hiding Session Toolbar hides hamburger menu, making re-enabling the toolbar impossible unless you know the shortcut to show the menu bar
Product:	[Applications] konsole	Reporter:	guimarcalsilva
Component:	general	Assignee:	Konsole Bugs <konsole-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	dipesh, nate, winter
Priority:	NOR
Version First Reported In:	master
Target Milestone:	---
Platform:	Neon
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=466107
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	konsole context menu attachment-1283353-0.html

Description guimarcalsilva 2023-02-19 19:53:37 UTC

SUMMARY

As a curious person, I saw the option to hide the toolbars in Konsole and I thought: "Wait... There's only one toolbar! I wonder what's the difference between the Main Toolbar and a Session Toolbar...". Turns out that if you have the hamburger menu (which is the default now), and you hide the Session Toolbar, the hamburger menu gets hidden as well, and there's no way of finding the option to bring the Session Toolbar back unless you also happen to know the shortcut to bring the menu bar back (CTRL+SHIFT+M).

There are a few possible solutions, but they all bring one drawback or another:

1. Make hiding the toolbar still keep the hamburger menu there. Drawback: Effectively you won't hide the toolbar because it will still need to be there to accommodate the hamburger menu. To completely hide it, you'll also need to enable the menu bar to hide the hamburger menu.

2. Do the same as suggestion 1 but show the menu bar automatically when you hide the toolbar. Pros: Hiding the toolbar won't be a two step process anymore. Drawbacks: This option would overlap with the option to "Show Menubar". E.g:

1. Hide the toolbar (which would show the menu bar)
2. Uncheck "Show Menubar" to hide it as well

You'll get an empty UI, bringing back the same problem of "how do I bring things back to normal?". An empty UI is only useful when running scripts that call Konsole, so disallowing that in normal usage would be fine (should probably be brought back for scripts only with a --hideui command line option). If this suggestion is chosen, it would be wise to change the name from "Show Menubar" to "Switch to Hamburger Menu".

3. Disallow hiding the toolbar in the first place (this will make Konsole inconsistent with other applications, like Dolphin, but would work in principle).

STEPS TO REPRODUCE
1. Go to Hamburger Menu > Settings > Toolbars shown
2. Deselect "Session Toolbar"

OBSERVED RESULT
Hamburger menu is gone and there's no menu bar to replace it. That means you can't also re-enable the toolbar unless you know the shortcut to bring the menu bar.

EXPECTED RESULT
The Hamburger Menu should always be visible when no menu bar is available, even if the user wants to hide the toolbar.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Kernel Version: 5.19.0-32-generic (64-bit)
Graphics Platform: Wayland
Processors: 6 × Intel® Core™ i5-9400F CPU @ 2.90GHz
Memory: 15,6 GiB of RAM
Graphics Processor: AMD Radeon RX 570 Series

Comment 1 Nate Graham 2023-02-22 00:18:35 UTC

Konsole is an app used by technical experts, and we assume that if you deliberately hide both of these UI elements, you know what you're doing. :) 

Regardless, the menu structure appears in the view context menu, which lets you re-enable the menubar, the toolbars, or both.

Comment 2 Allen Winter 2024-06-08 15:52:36 UTC

I managed to disable the menu bar (fumble-fingers, not purposefully) (must have pressed Ctrl+Shift+M somehow)

see the context menu in the attachment.  you can see no option for re-enabling menu.
I'm asking to put a View Menu option on the context menu

Comment 3 Allen Winter 2024-06-08 15:53:12 UTC

Created attachment 170274 [details]
konsole context menu

Comment 4 Sebastian Sauer 2024-11-20 11:06:14 UTC

(In reply to Allen Winter from comment #2)
> I managed to disable the menu bar (fumble-fingers, not purposefully) (must
> have pressed Ctrl+Shift+M somehow)
> 
> see the context menu in the attachment.  you can see no option for
> re-enabling menu.
> I'm asking to put a View Menu option on the context menu

Same for me and just like Allen (who is amazing developer I had the honor to work with during my 8 years at KDAB) I am actually with KDE (even as core developer hacking on plasma among many other things) since a decade. But yet only after t adding this Big report I realized that it's CTRL+SHIFT+M in Konsole and not CTRL+M like at other applications like Dolphin. So many thanks to the big reporter since otherwise I would only have figured out when looking at the current Konsole code.

Comment 5 tcanabrava 2024-11-20 13:35:53 UTC

Created attachment 175975 [details]
attachment-1283353-0.html

I believe adding hamburger menu to anything is a mistake, and I won't touch
the code that handles it.


On Wed, Nov 20, 2024 at 12:06 PM dipesh <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=466101
>
> dipesh <dipesh@gmx.de> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |dipesh@gmx.de
>
> --- Comment #4 from dipesh <dipesh@gmx.de> ---
> (In reply to Allen Winter from comment #2)
> > I managed to disable the menu bar (fumble-fingers, not purposefully)
> (must
> > have pressed Ctrl+Shift+M somehow)
> >
> > see the context menu in the attachment.  you can see no option for
> > re-enabling menu.
> > I'm asking to put a View Menu option on the context menu
>
> Same for me and just like Allen (who is amazing developer I had the honor
> to
> work with during my 8 years at KDAB) I am actually with KDE (even as core
> developer hacking on plasma among many other things) since a decade. But
> yet
> only after t adding this Big report I realized that it's CTRL+SHIFT+M in
> Konsole and not CTRL+M like at other applications like Dolphin. So many
> thanks
> to the big reporter since otherwise I would only have figured out when
> looking
> at the current Konsole code.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.