Bug 466080

Summary:	Content of XWayland steam is drawn too small when using HiDPI client scaling
Product:	[Plasma] plasmashell	Reporter:	Celeste Liu <uwu>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	kde, qydwhotmail
Priority:	NOR	Keywords:	regression
Version First Reported In:	5.27.0	Flags:	uwu: Wayland+
Target Milestone:	1.0
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=465733
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	status of steam

Description Celeste Liu 2023-02-19 12:44:10 UTC

Created attachment 156486 [details]
status of steam

SUMMARY

When I upgrade plasma from 5.26.90 to 5.27, steam (run in XWayland) rendered in the wrong scale except for window size.
All contents (text and image and button) are very small except the top bar.
My scale is 2, with only one enabled screen.

I don't know which component kde-gtk-config corresponds to, so I chose general.

STEPS TO REPRODUCE
1. upgrade to 5.27
2. open steam
3. look

OBSERVED RESULT

steam (run in XWayland) rendered in the wrong scale except for window size.
All contents (text and image and button) are very small except the top bar.

EXPECTED RESULT

all contents are scaled up by 2.

SOFTWARE/OS VERSIONS
Linux: Arch Linux 
KDE Plasma Version: 5.27
KDE Frameworks Version: 5.103
Qt Version: 5.15.8+kde+r181

ADDITIONAL INFORMATION

I tried https://invent.kde.org/plasma/kde-gtk-config/-/commit/95a66e22d484d9291f79770643865477e5f4aef8 and https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/56 , but it doesn't work.
Fushan Wen(@fusionfuture) reminded me that this might be related to steam using GTK2, so I opened a separate bug report.

Related: https://bugs.kde.org/show_bug.cgi?id=465733

Comment 1 David Edmundson 2023-02-19 13:01:54 UTC

You didn't mention https://invent.kde.org/plasma/plasma-workspace/commit/14c5b464f41f2b858453fd102ed57397755f9c26

does that help?

Comment 2 Celeste Liu 2023-02-19 13:48:41 UTC

(In reply to David Edmundson from comment #1)
> You didn't mention
> https://invent.kde.org/plasma/plasma-workspace/commit/
> 14c5b464f41f2b858453fd102ed57397755f9c26
> 
> does that help?

After this commit, the modified part of the code is actually back to the state of tag 5.27.0.

https://invent.kde.org/plasma/plasma-workspace/-/blob/14c5b464f41f2b858453fd102ed57397755f9c26/startkde/startplasma-wayland.cpp#L69
https://invent.kde.org/plasma/plasma-workspace/-/blob/v5.27.0/startkde/startplasma-wayland.cpp#L69

In fact, this string of changes is generated like this, `startplasma-wayland: Don't set GDK_SCALE and GDK_DPI_SCALE` is a modification that was added before 5.27, Nate tried to fix 465733 so reverted it, and added another commit to make users can override the settings, then Fushan Wen found a better way to solve that problem, so there is https://invent.kde.org/plasma/plasma-workspace/-/commit/14c5b464f41f2b858453fd102ed57397755f9c26 and https://invent.kde.org/plasma/kde-gtk-config/-/commit/95a66e22d484d9291f79770643865477e5f4aef8

Comment 3 Celeste Liu 2023-02-19 14:32:18 UTC

Sorry, I just found out that this is actually a problem caused by the steam update, but the update is very close to the release time of 5.27, which caused me to blame KDE.

https://github.com/ValveSoftware/steam-for-linux/issues/9209