Bug 465816

Summary: Audio does not play when global settings mute noises on modules Barnyard animals and Memory with Audio (post piano bug fix)
Product: [Applications] gcompris Reporter: ReadAlongToLearnEnglish
Component: generalAssignee: Jazeix Johnny <jazeix>
Status: RESOLVED FIXED    
Severity: normal CC: ReadAlongToLearnEnglish
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description ReadAlongToLearnEnglish 2023-02-16 06:04:03 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Go to global settings and disable audio voices and effects
2. Load "Explore farm animals" or "Audio Memory Game" (not exhaustive list) 
3. See popup saying activity requires sound and click Continue
4. Flip cards or click on animals


OBSERVED RESULT
Audio is not heard

EXPECTED RESULT
Audio should be heard

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma:  Ubuntu 20.04, Version 3.1 cloned from github recently.
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
I went back to v3.1 downloaded from the website as a .sh build and following these steps does not cause the bug (audio is heard) . I turned on Audio in global settings and heard audio while running the app.
Comment 1 Jazeix Johnny 2023-02-17 10:23:25 UTC
Git commit 07e3fc14236c730d3025ba4ef6d4d311a16a46c2 by Johnny Jazeix.
Committed on 17/02/2023 at 10:22.
Pushed by jjazeix into branch 'master'.

memory, for audio activities, bind the isMusicalActivity directly.
Else, the value is set to late in the process and in the main.qml, we don't consider the activity has audio and audio is not played if we disabled it in the configuration.

M  +2    -1    src/activities/memory/MemoryCommon.qml

https://invent.kde.org/education/gcompris/commit/07e3fc14236c730d3025ba4ef6d4d311a16a46c2
Comment 2 Jazeix Johnny 2023-02-17 10:23:33 UTC
Git commit 060302752ddc14b4a5d502fb0b6190913d2bc79a by Johnny Jazeix.
Committed on 17/02/2023 at 10:22.
Pushed by jjazeix into branch 'master'.

explore_farm_animals, explore_world_music, for audio activities, bind the isMusicalActivity directly.
Else, the value is set to late in the process and in the main.qml, we don't consider the activity has audio and audio is not played if we disabled it in the configuration.

M  +2    -1    src/activities/explore_farm_animals/ExploreLevels.qml

https://invent.kde.org/education/gcompris/commit/060302752ddc14b4a5d502fb0b6190913d2bc79a
Comment 3 Jazeix Johnny 2023-02-17 10:25:09 UTC
Thank you, there were the only two activities with the issue.
Comment 4 Jazeix Johnny 2023-02-17 10:25:17 UTC
Git commit 9607fc6a4e8d9d56df124938e9f998e5d505adc8 by Johnny Jazeix.
Committed on 17/02/2023 at 10:23.
Pushed by jjazeix into branch 'KDE/3.0'.

explore_farm_animals, explore_world_music, for audio activities, bind the isMusicalActivity directly.
Else, the value is set to late in the process and in the main.qml, we don't consider the activity has audio and audio is not played if we disabled it in the configuration.

M  +2    -1    src/activities/explore_farm_animals/ExploreLevels.qml

https://invent.kde.org/education/gcompris/commit/9607fc6a4e8d9d56df124938e9f998e5d505adc8
Comment 5 Jazeix Johnny 2023-02-17 10:25:25 UTC
Git commit 2c8339b62143d46a19b9f6ba3b6a09d1370171cb by Johnny Jazeix.
Committed on 17/02/2023 at 10:23.
Pushed by jjazeix into branch 'KDE/3.0'.

memory, for audio activities, bind the isMusicalActivity directly.
Else, the value is set to late in the process and in the main.qml, we don't consider the activity has audio and audio is not played if we disabled it in the configuration.

M  +2    -1    src/activities/memory/MemoryCommon.qml

https://invent.kde.org/education/gcompris/commit/2c8339b62143d46a19b9f6ba3b6a09d1370171cb