Bug 465800

Summary: Pre-chosen accent colours are not highlighted when they have keyboard focus
Product: [Applications] systemsettings Reporter: Jack Hill <jackhill3103>
Component: kcm_colorsAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: nate, noahadvs, tantalising007, uhhadd
Priority: NOR    
Version First Reported In: 5.27.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/a54df5f8be7bd9c2570a0dc53bec81c1ec20da53 Version Fixed/Implemented In: 5.27.2
Sentry Crash Report:

Description Jack Hill 2023-02-15 23:28:13 UTC 
SUMMARY
It makes it really confusing when the highlight disappears like this. Especially since there are two extra hidden tab presses (see additional information)

STEPS TO REPRODUCE
1. Open the colours KCM
2. Spam tab until the "From current wallpaper" radio button is highlighted
3. Press tab 13 times

OBSERVED RESULT
The "Custom" button should be highlighted. None of the options were highlighted during the after the previous 12 tab presses.

EXPECTED RESULT
Each colour should be highlighted.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20230213
KDE Plasma Version: 5.27.0
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.1.10-1-default (64-bit)
Graphics Platform: X11 

ADDITIONAL INFORMATION
It takes 13 presses even though there's 11 visible options (10 colours + 1 custom button). I think there's 1 extra press due to the radio button and for some reason there's 1 extra button for the custom colour picker before the actual button.
Comment 1 Bug Janitor Service 2023-02-16 12:12:18 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2629
Comment 2 Nate Graham 2023-02-21 15:46:58 UTC 
Git commit 5a66bb3c22cce96f49f271a6df04847317236f7d by Nate Graham, on behalf of Tanbir Jishan.
Committed on 21/02/2023 at 15:46.
Pushed by ngraham into branch 'master'.

kcms/color: Add highlight outline for color dots

It fixes the issue of tab press not highlighting color dots and one hidden
element taking focus once.
FIXED-IN: 5.27.2

M  +14   -0    kcms/colors/package/contents/ui/AccentColorUI.qml

https://invent.kde.org/plasma/plasma-workspace/commit/5a66bb3c22cce96f49f271a6df04847317236f7d
Comment 3 Nate Graham 2023-02-21 21:15:14 UTC 
Git commit a54df5f8be7bd9c2570a0dc53bec81c1ec20da53 by Nate Graham, on behalf of Tanbir Jishan.
Committed on 21/02/2023 at 21:15.
Pushed by ngraham into branch 'Plasma/5.27'.

kcms/color: Add highlight outline for color dots

It fixes the issue of tab press not highlighting color dots and one hidden
element taking focus once.
FIXED-IN: 5.27.2

This is a manual backport of
MR https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2629
because it did not cherry-pick cleanly.

M  +12   -0    kcms/colors/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/a54df5f8be7bd9c2570a0dc53bec81c1ec20da53