Bug 465773

Summary:	Build failure with raqm 0.10.0
Product:	[Applications] krita	Reporter:	Christophe Marin <christophe>
Component:	General	Assignee:	wolthera <griffinvalley>
Status:	RESOLVED FIXED
Severity:	normal	CC:	amy
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/f5595e09a3b90815ac6c9b7ce6b75b09bb9ea690	Version Fixed/Implemented In:
Sentry Crash Report:

Description Christophe Marin 2023-02-15 14:51:02 UTC

git hash: add6c004d

Relevant cmake log:
[  275s] -- Found Raqm: /usr/include (found suitable version "0.10.0", minimum required is "0.9.0")  


[ 1420s] /home/abuild/rpmbuild/BUILD/krita-5.2.40git.20230215T091621~add6c004d/libs/flake/text/KoSvgTextShape.cpp: In member function 'void KoSvgTextShape::relayout() const':
[ 1420s] /home/abuild/rpmbuild/BUILD/krita-5.2.40git.20230215T091621~add6c004d/libs/flake/text/KoSvgTextShape.cpp:557:46: error: too many arguments to function 'bool raqm_set_letter_spacing_range(raqm_t*, int, size_t, size_t)'
[ 1420s]   557 |                 raqm_set_letter_spacing_range(layout.data(),
[ 1420s]       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
[ 1420s]   558 |                                               static_cast<int>(letterSpacing.customValue * ftFontUnit * scaleToPixel),
[ 1420s]       |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 1420s]   559 |                                               false,
[ 1420s]       |                                               ~~~~~~
[ 1420s]   560 |                                               static_cast<size_t>(start),
[ 1420s]       |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 1420s]   561 |                                               static_cast<size_t>(length));
[ 1420s]       |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 1420s] In file included from /home/abuild/rpmbuild/BUILD/krita-5.2.40git.20230215T091621~add6c004d/libs/flake/text/KoSvgTextShape.cpp:12:
[ 1420s] /usr/include/raqm.h:162:1: note: declared here
[ 1420s]   162 | raqm_set_letter_spacing_range(raqm_t *rq,
[ 1420s]       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 1420s] /home/abuild/rpmbuild/BUILD/krita-5.2.40git.20230215T091621~add6c004d/libs/flake/text/KoSvgTextShape.cpp:565:44: error: too many arguments to function 'bool raqm_set_word_spacing_range(raqm_t*, int, size_t, size_t)'
[ 1420s]   565 |                 raqm_set_word_spacing_range(layout.data(),
[ 1420s]       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
[ 1420s]   566 |                                             static_cast<int>(wordSpacing.customValue * ftFontUnit * scaleToPixel),
[ 1420s]       |                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 1420s]   567 |                                             false,
[ 1420s]       |                                             ~~~~~~
[ 1420s]   568 |                                             static_cast<size_t>(start),
[ 1420s]       |                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 1420s]   569 |                                             static_cast<size_t>(length));
[ 1420s]       |                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 1420s] /usr/include/raqm.h:167:1: note: declared here
[ 1420s]   167 | raqm_set_word_spacing_range(raqm_t *rq,
[ 1420s]       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 1420s] make[2]: *** [libs/flake/CMakeFiles/kritaflake.dir/build.make:2562: libs/flake/CMakeFiles/kritaflake.dir/text/KoSvgTextShape.cpp.o] Error 1

Comment 1 Bug Janitor Service 2023-02-16 12:27:56 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1740

Comment 2 Invent Merge Service 2023-02-17 11:31:47 UTC

Git commit f5595e09a3b90815ac6c9b7ce6b75b09bb9ea690 by Merge Service, on behalf of Wolthera van Hövell tot Westerflier.
Committed on 17/02/2023 at 11:31.
Pushed by merge-service into branch 'master'.

Update to Raqm 0.10.0

Raqm 0.10.0 contains all our upstreamed patches so that makes things easier.

CCMAIL:kimageshop@kde.org

Part-of: <https://invent.kde.org/graphics/krita/-/merge_requests/1740>

M  +2    -4    3rdparty/ext_raqm/CMakeLists.txt
D  +0    -35   3rdparty/ext_raqm/fix_utf_16.patch
M  +1    -1    CMakeLists.txt
M  +0    -2    libs/flake/text/KoSvgTextShape.cpp

https://invent.kde.org/graphics/krita/commit/f5595e09a3b90815ac6c9b7ce6b75b09bb9ea690