Bug 465751

Summary: [5.27 Regression] Password prompt for VPN connection does not have password field in focus by default
Product: [Plasma] plasma-nm Reporter: Gurenko Alex <agurenko>
Component: generalAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: jan.molnar, kde, nate
Priority: NOR Keywords: regression
Version: 5.27.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=312325
Latest Commit: https://invent.kde.org/plasma/plasma-nm/commit/133ae5311f8553c16da63155ed06b05313988ec8 Version Fixed In: 5.27.1
Sentry Crash Report:

Description Gurenko Alex 2023-02-15 09:11:39 UTC 
SUMMARY

I've just upgraded from plasma 5.26.5 to 5.27.0 and default for vpn password prompt is changed. Password input field is no longer in focus by default


STEPS TO REPRODUCE
1. Click connect to a VPN with a password prompt


OBSERVED RESULT

Password prompt dialog now have "OK" button in focus by default

EXPECTED RESULT

Password input field should be in focus so you can start typing it right away


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora Linux 37 KDE Spin
KDE Plasma Version: 5.27.0
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Comment 1 Kai Uwe Broulik 2023-02-15 10:00:28 UTC 
Looks like a regression from https://invent.kde.org/plasma/plasma-nm/-/commit/ce6a0cc8251a720828bbe680750aa16a42408797
Comment 2 Vlad Zahorodnii 2023-02-15 10:14:07 UTC 
That commit works fine. My bisect session resulted in

84b1e5079e490195d111f9c62bc00915fae3b903 is the first bad commit
commit 84b1e5079e490195d111f9c62bc00915fae3b903
Comment 3 Bug Janitor Service 2023-02-15 11:48:38 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/216
Comment 4 Nicolas Fella 2023-02-15 17:00:06 UTC 
Git commit cadf1478f7585f07523c239eef6ba6217044c3ac by Nicolas Fella.
Committed on 15/02/2023 at 11:46.
Pushed by nicolasfella into branch 'master'.

Revert "Use QWindow instead of KWindowSystem to set KeepAbove"

QWidget::setWindowFlag() has side-effects that break the set focus widget

This reverts commit 84b1e5079e490195d111f9c62bc00915fae3b903.

M  +2    -1    kded/pindialog.cpp
M  +2    -1    kded/secretagent.cpp
M  +2    -1    libs/handler.cpp

https://invent.kde.org/plasma/plasma-nm/commit/cadf1478f7585f07523c239eef6ba6217044c3ac
Comment 5 Nicolas Fella 2023-02-15 17:00:42 UTC 
Git commit 133ae5311f8553c16da63155ed06b05313988ec8 by Nicolas Fella.
Committed on 15/02/2023 at 17:00.
Pushed by nicolasfella into branch 'Plasma/5.27'.

Revert "Use QWindow instead of KWindowSystem to set KeepAbove"

QWidget::setWindowFlag() has side-effects that break the set focus widget

This reverts commit 84b1e5079e490195d111f9c62bc00915fae3b903.

(cherry picked from commit cadf1478f7585f07523c239eef6ba6217044c3ac)

M  +2    -1    kded/pindialog.cpp
M  +2    -1    kded/secretagent.cpp
M  +2    -1    libs/handler.cpp

https://invent.kde.org/plasma/plasma-nm/commit/133ae5311f8553c16da63155ed06b05313988ec8
Comment 6 Bug Janitor Service 2023-10-20 12:29:21 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/299
Comment 7 Kai Uwe Broulik 2023-10-20 13:00:26 UTC 
Git commit 589c58ed7f2dedff0299786ae8fc3706a0d8f37f by Kai Uwe Broulik.
Committed on 20/10/2023 at 14:28.
Pushed by broulik into branch 'Plasma/5.27'.

Revert "Don't force active dialogs right after showing"

This breaks focussing the password dialog when connecting to a OpenVPN
from the Networks applet.

Better revert this on LTS, and then figure it out properly for 6.0.

This reverts commit ce6a0cc8251a720828bbe680750aa16a42408797.

M  +1    -0    kded/pindialog.cpp
M  +1    -0    kded/secretagent.cpp
M  +1    -0    libs/handler.cpp

https://invent.kde.org/plasma/plasma-nm/-/commit/589c58ed7f2dedff0299786ae8fc3706a0d8f37f
Comment 8 Jan Molnar 2023-11-10 13:41:51 UTC 
*** Bug 469398 has been marked as a duplicate of this bug. ***