Bug 465600

Summary: TypeError: Cannot read property 'skipTaskbar' of undefined
Product: [Plasma] kwin Reporter: archinax
Component: scriptsAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: kde, nate
Priority: NOR    
Version First Reported In: master   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description archinax 2023-02-11 22:40:35 UTC
SUMMARY
Javascript error when hovering over taskbar while auto-hide is turned on.


STEPS TO REPRODUCE
1. Configure taskbar to auto-hide: Right click on empty space in taskbar -> Enter Edit Mode -> More Options -> Auto Hide
2. Listen to logs (e.g. with `journalctl -f`)
3. Move your mouse to show the taskbar and then move it away to hide it
4. Observe the error

OBSERVED RESULT
kwin_x11[1518]: file:///usr/share/kwin/scripts/synchronizeskipswitcher/contents/code/main.js:10: TypeError: Cannot read property 'skipTaskbar' of undefined

EXPECTED RESULT
No error in error log

SOFTWARE/OS VERSIONS
Windows: n/a
macOS: n/a
Linux/KDE Plasma: 6.1.11 (64-bit)
(available in About System)
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Comment 1 archinax 2023-02-12 10:27:30 UTC
Fixed in https://invent.kde.org/plasma/kwin/-/merge_requests/3581
Sorry, didn't include BUG: keyword in the commit message.
Comment 2 Vlad Zahorodnii 2024-08-26 13:51:03 UTC
Git commit a418d2f13eba884b5290c8b03207e780ade277e9 by Vlad Zahorodnii.
Committed on 26/08/2024 at 13:38.
Pushed by vladz into branch 'master'.

plugins/synchronizeskipswitcher: Fix Window::skipTaskbarChanged handler

The Window::skipTaskbarChanged signal no longer has a Window argument.

M  +5    -6    src/plugins/synchronizeskipswitcher/package/contents/code/main.js

https://invent.kde.org/plasma/kwin/-/commit/a418d2f13eba884b5290c8b03207e780ade277e9
Comment 3 Vlad Zahorodnii 2024-08-26 14:05:03 UTC
Git commit c4680a574c17c67ce19fbbfd1f090911980c6fb4 by Vlad Zahorodnii.
Committed on 26/08/2024 at 13:52.
Pushed by vladz into branch 'Plasma/6.1'.

plugins/synchronizeskipswitcher: Fix Window::skipTaskbarChanged handler

The Window::skipTaskbarChanged signal no longer has a Window argument.


(cherry picked from commit a418d2f13eba884b5290c8b03207e780ade277e9)

Co-authored-by: Vlad Zahorodnii <vlad.zahorodnii@kde.org>

M  +5    -6    src/plugins/synchronizeskipswitcher/package/contents/code/main.js

https://invent.kde.org/plasma/kwin/-/commit/c4680a574c17c67ce19fbbfd1f090911980c6fb4