| Summary: | Crash when discarding changes in Quick Settings | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Thomas Wuillemin <thomas.wuillemin> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | kde, nate |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 5.26.90 | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/systemsettings/commit/988ee832615a396595108159f24a8e342bd22612 | Version Fixed In: | 5.27.4 |
| Sentry Crash Report: | |||
|
Description
Thomas Wuillemin
2023-02-09 15:13:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1381 A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/198 Git commit 4d55735ce0b0ae134c4c69d6b92e2ac1af8970c7 by David Redondo. Committed on 10/02/2023 at 13:07. Pushed by davidre into branch 'master'. kcms/landingPage: Remove double definition of onClickHandler No need to do it twice. Also this uncovered a bug in systemsettings M +0 -2 kcms/landingpage/package/contents/ui/MostUsedIcon.qml https://invent.kde.org/plasma/plasma-desktop/commit/4d55735ce0b0ae134c4c69d6b92e2ac1af8970c7 Git commit a943561ac6f4586ccc81b5009a17d38017e7fee1 by David Redondo. Committed on 10/02/2023 at 14:05. Pushed by davidre into branch 'Plasma/5.27'. kcms/landingPage: Remove double definition of onClickHandler No need to do it twice. Also this uncovered a bug in systemsettings (cherry picked from commit 4d55735ce0b0ae134c4c69d6b92e2ac1af8970c7) M +0 -2 kcms/landingpage/package/contents/ui/MostUsedIcon.qml https://invent.kde.org/plasma/plasma-desktop/commit/a943561ac6f4586ccc81b5009a17d38017e7fee1 Git commit 58907166d6600de3ad654922689af2a6bd0e1c51 by David Redondo. Committed on 24/03/2023 at 08:28. Pushed by davidre into branch 'master'. Cancel pending resolveChanges dialog when a new one is started We run a nested event loop while the message dialog is shown and is waiting for user input. When during this a new request to open another module happened (via dbus) we would show a second dialog and run another event loop. After the first dialog was answered with discard changes, the module was destroyed, so the second discard answer chrashes trying to reset module which was no longer around. Instead prevent this by rejecting the first dialog (effect being staying on the current module and doing nothing) before showing the new one. This also ensures that afterwards the correct module is opened (the one from the second request). FIXED-IN:5.27.4 M +21 -13 core/ModuleView.cpp https://invent.kde.org/plasma/systemsettings/commit/58907166d6600de3ad654922689af2a6bd0e1c51 Git commit 988ee832615a396595108159f24a8e342bd22612 by David Redondo. Committed on 24/03/2023 at 15:32. Pushed by davidre into branch 'Plasma/5.27'. Cancel pending resolveChanges dialog when a new one is started We run a nested event loop while the message dialog is shown and is waiting for user input. When during this a new request to open another module happened (via dbus) we would show a second dialog and run another event loop. After the first dialog was answered with discard changes, the module was destroyed, so the second discard answer chrashes trying to reset module which was no longer around. Instead prevent this by rejecting the first dialog (effect being staying on the current module and doing nothing) before showing the new one. This also ensures that afterwards the correct module is opened (the one from the second request). FIXED-IN:5.27.4 (cherry picked from commit 58907166d6600de3ad654922689af2a6bd0e1c51) M +21 -13 core/ModuleView.cpp https://invent.kde.org/plasma/systemsettings/commit/988ee832615a396595108159f24a8e342bd22612 |