| Summary: | Partition restore fails with misleading message about unavailable space | ||
|---|---|---|---|
| Product: | [Applications] partitionmanager | Reporter: | Gabriel Barros <descartavel1> |
| Component: | general | Assignee: | Andrius Štikonas <andrius> |
| Status: | REPORTED --- | ||
| Severity: | major | ||
| Priority: | NOR | ||
| Version First Reported In: | 22.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Gabriel Barros
2023-02-03 20:04:54 UTC
Message is a bit misleading, but what you are trying to do is not a valid operation. You are trying to restore disk image into a partition (i.e. restore /dev/sda into /dev/sda1). At the moment partition manager does not support restoring whole disk image. I see. Thank you. The manual does say it works on a empty region, so I assumed wrong. Guess the feature is not well named either, not just the error. Menu items should be called "restore partition" not just "restore"/"backup". (In reply to Gabriel Barros from comment #2) > I see. Thank you. The manual does say it works on a empty region, so I > assumed wrong. Guess the feature is not well named either, not just the > error. > > Menu items should be called "restore partition" not just "restore"/"backup". Hmm, in principle these menu entries are in "Partition". All operations in it are partition specific. There is also device menu for device-wide things. > these menu entries are in "Partition". All operations in it are partition specific. There is also device menu for device-wide things.
makes sense for the menus.
In the "devices" menu i see "restore partion table"
On the partition menu there's only "restore" and that do make sense in that menu as you mention.
I think my confusion is when you right click an empty drive's empty space. is that showing me the menu for partition or device (since there's no partition)
(In reply to Gabriel Barros from comment #4) > I think my confusion is when you right click an empty drive's empty space. > is that showing me the menu for partition or device (since there's no > partition) That's still the same partition menu. You get device menu if you right click on the very top line (or if you have a floating device panel, you can right click there). If you still think that's bit confusing, I guess we could add extra word Partition there. I.e. "Backup partition", "Restore partition". But we already have a tooltip that shows that when you hover your mouse above "Backup" menu entry. Reading the whole history again, i do think it is confusing i said: > > 2. click the unallocated space and from context menu select "Restore" and you explained my mistake as: > Message is a bit misleading, but what you are trying to do is not a valid operation. You are trying to restore disk image into a partition (i.e. restore /dev/sda into /dev/sda1). So, when i click the "unallocated" I'm clicking "sda1"? that is confusing, yes. What do you suggest we change the text to? |