Bug 465082

Summary:	Not consistent place of button "Get New" comparing to other pages in Splash Screen
Product:	[Applications] systemsettings	Reporter:	Piotr Mierzwinski <piotr.mierzwinski>
Component:	kcm_splashscreen	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	justin.zobel, nate, piotr.mierzwinski
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	5.26.90
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Piotr Mierzwinski 2023-01-31 12:29:09 UTC

SUMMARY
At the first glance I thought that button "Get New" is missing in page "Splash Screen". Later I found it in top right corner, instead of bottom right corner.
Would be nice to in all pages button "Get New" would be placed in the same location.

STEPS TO REPRODUCE
1. start System Settings
2. go to Appearance -> Splash Screen
3. 

OBSERVED RESULT
Button "Get New" placed at the top right corner

EXPECTED RESULT
Button "Get New" should be placed at the bottom right corner as it is on other pages

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.103
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Graphics Platform X11

Comment 1 Justin Zobel 2023-02-01 05:27:44 UTC

Agreed, this should be moved.

Comment 2 Nate Graham 2023-02-06 19:18:05 UTC

Looks like one of our header-to-footer patches got merged into 5.27, but the other ones didn't make it. We can either revert it for now or live with it, because all the other ones are going to be like this in 6.0.

[looks into it]

...Actually, we can't revert it since it changed a string, so reverting would also be another string change, and we're far beyond the string freeze. So we've gotta live with it for 5.27.

Comment 3 Piotr Mierzwinski 2023-02-06 19:42:16 UTC

(In reply to Nate Graham from comment #2)
> Looks like one of our header-to-footer patches got merged into 5.27, but the
Please consider version I put in description, so:
"KDE Plasma Version: 5.27.80"
I suppose this is 5.28, ..... or 6.0
In header where I reported "Version" such version was missing.
BTW. I use "Neon Unstable Edition", I forgot mention in description.

Comment 4 Nate Graham 2023-02-06 19:44:40 UTC

Then it's doubly intentional, since you're running git master software and things are expected to be in a state of flux. You just happened to stumble on an in-progress project that isn't 100% complete yet. :)