Bug 465052

Summary: CardsGridView has no padding on the left side
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Thiago Sueto <herzenschein>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: josh, notmart
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: CardGridView example from Kirigami Gallery tutorial.

Description Thiago Sueto 2023-01-30 20:29:32 UTC
Created attachment 155798 [details]
CardGridView example from Kirigami Gallery tutorial.

When attempting to reproduce the example in https://develop.kde.org/docs/use/kirigami/introduction-kirigami-gallery/ , the result lacks left padding between the cards and the left side of the window.

The code example is added as an attachment. It can be run with qmlscene.
Comment 1 Bug Janitor Service 2023-02-01 09:42:53 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/950
Comment 2 Marco Martin 2023-02-01 10:07:21 UTC
Git commit 6953547bdaecaefea3cc4ca191dadd3bacb1ae6b by Marco Martin.
Committed on 01/02/2023 at 10:06.
Pushed by mart into branch 'kf5'.

Take into account side margins

In the weird anchors calculations of CardsGridView take into account
side margins, fixing the layout problem

M  +3    -2    src/controls/private/CardsGridViewPrivate.qml

https://invent.kde.org/frameworks/kirigami/commit/6953547bdaecaefea3cc4ca191dadd3bacb1ae6b
Comment 3 Marco Martin 2023-02-01 10:08:03 UTC
Git commit 14a9ecd55d8ace2aff2b2c922b1c0a967f03ffbe by Marco Martin.
Committed on 01/02/2023 at 10:07.
Pushed by mart into branch 'master'.

Take into account side margins

In the weird anchors calculations of CardsGridView take into account
side margins, fixing the layout problem

M  +3    -2    src/controls/private/CardsGridViewPrivate.qml

https://invent.kde.org/frameworks/kirigami/commit/14a9ecd55d8ace2aff2b2c922b1c0a967f03ffbe