Bug 465048

Summary:	"Make window titlebars accent-colored" Doesn't use the Highlight color when no accent color is specified, so it looks broken
Product:	[Applications] systemsettings	Reporter:	Natalie Clarius <natalie_clarius>
Component:	kcm_colors	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	CONFIRMED ---
Severity:	normal	CC:	kde, nate, noahadvs, tantalising007, uhhadd
Priority:	NOR
Version First Reported In:	5.26.5
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=465593
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Natalie Clarius 2023-01-30 16:08:00 UTC

SUMMARY
***
The option in color scheme settings to "Make window titlebars accent-colored" works rather inconsistently.
***

STEPS TO REPRODUCE
1. System Settings > Color
2. Edit a color scheme
3. Options > Make window titlebars accent-colored

OBSERVED RESULT
- In general, it doesn't work for the accent color from the current color scheme (I would expect Breeze Blue to be used for this option with the Breeze themes).
- For copies of Breeze Light and Breeze dark with the option enabled, it applies the color not only to the titlebar but also to the header.
- For Breeze Light and Breeze Dark, it applies a fainter version also to inactive windows, whereas for Breeze Classic, inactive windows keep their original background color.
- Whenever the the color is applied to the active window, it doesn't use the actual accent color, but some fainter version of it.

EXPECTED RESULT
- The accent color gets applied in its original version to the titlebar of the active window and possibly in a more finted version to inactive windows, and regardless of which accent color mode or which base color scheme is used.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.8
Kernel Version: 6.1.5-arch2-1 (64-bit)
Graphics Platform: X11

Comment 1 Nate Graham 2023-02-06 18:37:45 UTC

#1 is a bug, others are intended as side effects of those color schemes using Header Colors to unify the titlebar and toolbar appearance.

Comment 2 Natalie Clarius 2023-02-06 18:43:07 UTC

For 2 and 4, if this is intentional I find it slightly misleadingly worded in the options. (I thought it was a bug anyway.)

What's the reason for 3? That difference between themes seems pretty unpredictable to me.

Comment 3 Nate Graham 2023-02-06 18:50:15 UTC

3 is also intentional so that there's a visual change when the window becomes inactive. The thing that got accent-color (whatever it is, whether it's the titlebar only, or the titlebar and toolbar) de-saturates to preserve that visual change for inactive windows.

I think the confusion would be reduced with a simple wording change: Bug 455809.

Comment 4 Natalie Clarius 2023-02-06 18:54:43 UTC

> The thing that got accent-color (whatever it is, whether it's the titlebar only, or the titlebar and toolbar) de-saturates to preserve that visual change for inactive windows.

But it doesn't do that in Breeze Classic. It uses the background color, not the desaturated accent color.

Comment 5 Nate Graham 2023-02-10 20:43:02 UTC

That's true, we probably should make that consistent one way or the other. Please file a new bug report for it.

Comment 6 Natalie Clarius 2023-02-11 17:20:06 UTC

https://bugs.kde.org/show_bug.cgi?id=465593