Summary: | Custom tiling requires Present Windows effect, but there's no notification for that | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Jin Liu <ad.liu.jin> |
Component: | Custom Tiling | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | bugseforuns, kde, kde, notmart, v |
Priority: | NOR | ||
Version: | 5.26.90 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/kwin/commit/37e5db8bb7264db2760dbb183e1b3e2c0c9445bb | Version Fixed In: |
Description
Jin Liu
2023-01-29 04:18:04 UTC
Well found. I don't think that's the right fix, we should make it just work. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3518 Git commit c0fa51c7842eb801556495f59a9dd587f431f853 by Vlad Zahorodnii, on behalf of David Edmundson. Committed on 02/02/2023 at 09:13. Pushed by vladz into branch 'master'. effects/tileseditor: Drop unused imports Imports come at a big cost when they're unused. Also we shouldn't be importing WindowView from a different plugin. If that effect is disabled it meant tileseditor would fail to load. M +0 -4 src/effects/tileseditor/qml/ResizeCorner.qml M +0 -6 src/effects/tileseditor/qml/ResizeHandle.qml M +0 -4 src/effects/tileseditor/qml/TileDelegate.qml M +1 -3 src/effects/tileseditor/qml/main.qml https://invent.kde.org/plasma/kwin/commit/c0fa51c7842eb801556495f59a9dd587f431f853 Git commit 37e5db8bb7264db2760dbb183e1b3e2c0c9445bb by David Edmundson. Committed on 02/02/2023 at 09:14. Pushed by davidedmundson into branch 'cherry-pick-c0fa51c7'. effects/tileseditor: Drop unused imports Imports come at a big cost when they're unused. Also we shouldn't be importing WindowView from a different plugin. If that effect is disabled it meant tileseditor would fail to load. (cherry picked from commit c0fa51c7842eb801556495f59a9dd587f431f853) M +0 -4 src/effects/tileseditor/qml/ResizeCorner.qml M +0 -6 src/effects/tileseditor/qml/ResizeHandle.qml M +0 -4 src/effects/tileseditor/qml/TileDelegate.qml M +1 -3 src/effects/tileseditor/qml/main.qml https://invent.kde.org/plasma/kwin/commit/37e5db8bb7264db2760dbb183e1b3e2c0c9445bb *** Bug 465186 has been marked as a duplicate of this bug. *** Wow good find, i actually signed up to the bug tracker just to report this. The temp fix worked for me |