Bug 464814

Summary:	Show a confirmation popup when pressing the back button on an edit
Product:	[Applications] Koko	Reporter:	Jack Hill <jackhill3103>
Component:	General	Assignee:	Unassigned bugs <unassigned-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/koko/commit/7ca4400208764f7b10ba16186282867398edee47	Version Fixed/Implemented In:
Sentry Crash Report:

Description Jack Hill 2023-01-25 17:40:05 UTC

SUMMARY
A user may go back by accident, in which case they'll lose whatever edits they've made. It would be good to have a confirmation dialogue.

STEPS TO REPRODUCE
1. Open an image
2. Click edit in the toolbar
3. Do one of the edits
4. Click the back button

OBSERVED RESULT
The app goes back to showing the original image

EXPECTED RESULT
There should be an overlay sheet saying something like "Are you sure you want to discard all changes? Yes/No"

SOFTWARE/OS VERSIONS
Koko: 22.11 built from source
Operating System: openSUSE Tumbleweed 20230123
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Kernel Version: 6.1.7-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION

Comment 1 Carl Schwan 2023-01-25 18:11:06 UTC

Git commit 7ca4400208764f7b10ba16186282867398edee47 by Carl Schwan.
Committed on 25/01/2023 at 18:10.
Pushed by carlschwan into branch 'master'.

Ask for confirmation before discarding edits

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

A  +63   -0    src/qml/Dialog/ConfirmDiscardingChange.qml     [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)]
M  +21   -3    src/qml/EditorView.qml
M  +1    -0    src/resources.qrc

https://invent.kde.org/graphics/koko/commit/7ca4400208764f7b10ba16186282867398edee47