Bug 464639

Summary:	When detaching a tab, toolbars are always shown in the new window
Product:	[Applications] kate	Reporter:	Kishore Gopalakrishnan <kishore96>
Component:	application	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	byebyebugaylon
Priority:	NOR
Version First Reported In:	22.12.1
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Kishore Gopalakrishnan 2023-01-22 09:44:45 UTC

SUMMARY
When a tab is detached from an existing Kate window using the right-click menu, Kate's toolbar is always shown in the new window, regardless of whether the user has previously chosen to hide the toolbars.

STEPS TO REPRODUCE
1. Go to 'Settings > toolbars shown' and hide both of Kate's toolbars
2. Relaunch Kate and check that the toolbars are not shown
3. Open multiple tabs in the same Kate window
4. Right-click on one of the tabs (in the tabbar) and click 'detach document'

OBSERVED RESULT
In the new window, Kate's toolbars are shown again

EXPECTED RESULT
Kate should always follow the user's toolbar configuration

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.26.90
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Kernel Version: 6.1.7-arch1-1 (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
The toolbars are correctly hidden when opening a new window through krunner or through ctrl+shift+N.

Comment 1 Bug Janitor Service 2023-02-16 11:55:48 UTC

A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/1109

Comment 2 Christoph Cullmann 2023-02-17 20:46:54 UTC

Git commit 23eb0e567d2e4321b9c59a148e2e4b3a9c13f082 by Christoph Cullmann, on behalf of Waqar Ahmed.
Committed on 17/02/2023 at 20:40.
Pushed by cullmann into branch 'master'.

Save global options of active window before creating new

So that the new window shows anything that was changed by the user e.g.,
if the user hid the tabbar and created a new window, the new window
should have the tabbar hidden.

With this change we save the options as soon as the user checks/unchecks
one of the options under "Settings" menu
Related: bug 465064

M  +27   -0    apps/lib/autotests/kate_view_mgmt_tests.cpp
M  +1    -0    apps/lib/autotests/kate_view_mgmt_tests.h
M  +4    -0    apps/lib/katemainwindow.cpp

https://invent.kde.org/utilities/kate/commit/23eb0e567d2e4321b9c59a148e2e4b3a9c13f082

Comment 3 Waqar Ahmed 2023-02-26 10:50:03 UTC

Git commit a84fbe4910230ef029c40c19c85aa6a402622370 by Waqar Ahmed.
Committed on 26/02/2023 at 10:43.
Pushed by waqar into branch 'release/22.12'.

Save global options of active window before creating new

So that the new window shows anything that was changed by the user e.g.,
if the user hid the tabbar and created a new window, the new window
should have the tabbar hidden.

With this change we save the options as soon as the user checks/unchecks
one of the options under "Settings" menu
Related: bug 465064

M  +27   -0    apps/lib/autotests/kate_view_mgmt_tests.cpp
M  +1    -0    apps/lib/autotests/kate_view_mgmt_tests.h
M  +4    -0    apps/lib/katemainwindow.cpp

https://invent.kde.org/utilities/kate/commit/a84fbe4910230ef029c40c19c85aa6a402622370

Comment 4 Kishore Gopalakrishnan 2023-03-26 05:42:17 UTC

No longer reproducible on kate 23.03.80

Comment 5 Waqar Ahmed 2023-04-04 18:10:54 UTC

*** Bug 468149 has been marked as a duplicate of this bug. ***