Bug 464560

Summary: When ledger option "Show group header between transactions" is disabled, reconciliation header still displays
Product: [Applications] kmymoney Reporter: Brant Gardner <brantcgardner>
Component: ux-uiAssignee: KMyMoney Devel Mailing List <kmymoney-devel>
Status: RESOLVED FIXED    
Severity: minor CC: brantcgardner
Priority: NOR    
Version First Reported In: 5.1.3   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: https://invent.kde.org/office/kmymoney/commit/9f64cb4f0d4b56c2e4e8b2258cf6f123d3741c13 Version Fixed In: 5.2
Sentry Crash Report:

Description Brant Gardner 2023-01-20 16:38:55 UTC 
SUMMARY
The most recent upgrade (for me) added group headers, defaulting to on.  For my own use case, these are overly verbose so I toggled them off.  Doing so removes many of the group headers but Reconciliation headers remain regardless of the chosen value of this option.

STEPS TO REPRODUCE
1. Go into Settings->Configure KMyMoney
2. Go to Ledger section.
3. Toggle option "Show group header between transactions" to off.

OBSERVED RESULT
If you go to Ledger, you will see that headers for Last Reconciliation are still displayed (all other group headers are properly disabled).

EXPECTED RESULT
Per the documentation, the definition of "group headers" should specifically include Last Reconciliation headers, so it would be expected that they would hide and show per the configuration option.

SOFTWARE/OS VERSIONS
Linux: Gentoo Linux 2.9
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.8
Kernel Version: 5.15.80-gentoo-x86_64 (64-bit)

ADDITIONAL INFORMATION
Graphics Platform: Wayland
Comment 1 Jack 2023-01-20 17:50:08 UTC 
I can confirm with Version 5.1.3-caa1baff4, which is a fairly recent Appimage version on Linux.  Just thinking out loud, I wonder if the reconcile headers should be treated the same as the other group headers, or if they deserve their own configuration item.  It might also make sense (but would clearly be more work) to separate the display of the most recent reconciliation header from all previous ones.
Comment 2 Brant Gardner 2023-01-22 16:39:00 UTC 
Being able to separately set visibility for the most recent reconciliation would be fantastic!  Maybe that will come along in some future release.
Comment 3 Thomas Baumgart 2023-01-28 11:15:39 UTC 
Git commit 9f64cb4f0d4b56c2e4e8b2258cf6f123d3741c13 by Thomas Baumgart.
Committed on 28/01/2023 at 11:15.
Pushed by tbaumgart into branch 'master'.

Implement setting for reconciliation headers

This setting allows to suppress display of all reconciliation headers,
suppress all of them but the last one or to display all available.

M  +83   -46   kmymoney/dialogs/settings/ksettingsregister.ui
M  +13   -0    kmymoney/kmymoney.cpp
M  +34   -1    kmymoney/models/specialledgeritemfilter.cpp
M  +5    -0    kmymoney/models/specialledgeritemfilter.h
M  +9    -0    kmymoney/mymoney/mymoneyenums.h
M  +12   -4    kmymoney/mymoney/storage/reconciliationmodel.cpp
M  +12   -1    kmymoney/mymoney/storage/reconciliationmodel.h
M  +9    -0    kmymoney/settings/kmymoney.kcfg
M  +9    -5    kmymoney/views/ledgerviewpage.cpp
M  +15   -0    kmymoney/views/ledgerviewsettings.cpp
M  +12   -0    kmymoney/views/ledgerviewsettings.h

https://invent.kde.org/office/kmymoney/commit/9f64cb4f0d4b56c2e4e8b2258cf6f123d3741c13
Comment 4 Jack 2023-02-04 00:09:12 UTC 
Will this get backported to 5.1?
In master, when I click apply after changing the value of that new dropdown, I sometimes get a crash (I haven't gotten a backtrace yet, but will keep trying.)  However, in some of my accounts, no matter what the setting, the most recent reconcile header is not being displayed.  I can't find any pattern of which accounts do or do not show that header.