Bug 464555

Summary: KDE Connect SMS group chat issues: last message shows only one person in a 3 person group chat , KDE Connect does not distinguish messages from different people
Product: [Applications] kdeconnect Reporter: Rigoberto Leyva Salmeron <rleyvasal>
Component: messaging-applicationAssignee: Simon Redman <simon>
Status: RESOLVED FIXED    
Severity: major    
Priority: NOR    
Version First Reported In: 22.12.1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/network/kdeconnect-android/commit/9db4c885a5001cadab9b5f2d269165e3d20dc3de Version Fixed/Implemented In:
Sentry Crash Report:

Description Rigoberto Leyva Salmeron 2023-01-20 15:26:12 UTC 
SUMMARY
When opening SMS on KDE Connect only one person shows in a 3 person group message.  One person shows on the left conversation window, and on the right window only the name of the person who sent last message shows on the top title.  Also KDE connect does not recognized the person who sent a message -all the messages have the same format and not tagged with a person's name. 


STEPS TO REPRODUCE
1.  Create a 3 person group SMS message
2.  When message is received from other two people,  only one person shows in the conversation left window and on the title of the right window the name of the last person who send a message shows. Also, there is no way to tell which person sent which message because messages are not tagged with person's name. 

OBSERVED RESULT
When creating a 3 person group SMS message, only the person who sent last message shows in the conversation left window and on the right window. Also the right window does not recognize which person sent the messages - All the messages have the same format

EXPECTED RESULT
When creating a 3 person group SMS message, the 3 persons shows in the conversation left window. And also the right window should recognize which person sent the messages - All the messages have the same format and not tagged with the person who sent it. 

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE Neon
(available in About System)
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.5
Comment 1 Simon Redman 2023-01-21 14:16:20 UTC 
Thanks for reporting this.

In spite of my long believe to the contrary, it looks like this is actually due to the Android app misbehaving!

Did you start experiencing this around the time the most-recent version of the Android app was pushed? That was January 6, 2023.
Comment 2 Simon Redman 2023-01-21 14:20:03 UTC 
Correction: The interesting release of the Android app was December 27, 2022. Prior to that, the previous release was v1.19.1 from January 24, 2022.
Comment 3 Simon Redman 2023-01-22 20:16:10 UTC 
Git commit 9db4c885a5001cadab9b5f2d269165e3d20dc3de by Simon Redman.
Committed on 22/01/2023 at 20:16.
Pushed by sredman into branch 'master'.

[SMS Plugin] Fix handling for addresses list of multi-target group messages

## Summary

Fix a logic error in the SMS plugin which caused it to skip the addresses of other targets when reporting group messages.

Notionally, this bug originated with the logic change in !197, where everything switched to using the android-smsmms library.

## Test Plan

### Before:
Group messages would be returned as single-target messages between you and the sender, meaning the desktop app would have a bad time showing them.

### After:
Group messages are returned with the appropriate list of addresses, the desktop app groups them appropriately.

M  +1    -1    src/org/kde/kdeconnect/Plugins/SMSPlugin/SmsMmsUtils.java

https://invent.kde.org/network/kdeconnect-android/commit/9db4c885a5001cadab9b5f2d269165e3d20dc3de
Comment 4 Rigoberto Leyva Salmeron 2023-01-22 20:19:15 UTC 
Not sure when the issue started happening as I don't regularly send group messages. Thanks for addressing this issue.