Bug 464518

Summary:	Nightly Windows build fails to load Python plugins
Product:	[Applications] krita	Reporter:	Freya Lupen <penguinflyer2222>
Component:	General	Assignee:	amyspark <amy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	amy
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/krita/commit/ed6d5e622f4376cc6888f4cc2bb5b397ef644e8c	Version Fixed/Implemented In:
Sentry Crash Report:

Description Freya Lupen 2023-01-19 19:11:20 UTC

SUMMARY
On the latest Windows Nightlys, Krita logs this message and Python plugins do not load.
`Loading plugin "C:/Users/name/Applications/krita-nightly-x64-5.2.0-prealpha-f5e7f50ac8/lib/kritaplugins/kritapykrita.dll" failed,  "Cannot load library C:\\Users\\name\\Applications\\krita-nightly-x64-5.2.0-prealpha-f5e7f50ac8\\lib\\kritaplugins\\kritapykrita.dll: The specified module could not be found."`
kritapykrita.dll does exist at that location.

STEPS TO REPRODUCE
Run Krita and try to load a Python plugin. (Or just check the log on startup.)

OBSERVED RESULT
Python plugins do not load.

EXPECTED RESULT
Python plugins load.

SOFTWARE/OS VERSIONS
Krita 5.2.x git 5e666c0df9

ADDITIONAL INFORMATION
Works as expected on Linux.

Comment 1 amyspark 2023-01-23 22:18:17 UTC

Can confirm, commit fa671d407f. I'll look into it now.

Comment 2 amyspark 2023-01-24 00:43:54 UTC

CI isn't deploying Python 3.10, it's deploying still 3.8. This doesn't match 3rdparty, so I'll have to revert the upgrade.

I'm testing the patch along with some other stuff, I'll send it by tonight's builds.

Comment 3 amyspark 2023-01-24 03:27:20 UTC

Git commit ed6d5e622f4376cc6888f4cc2bb5b397ef644e8c by L. E. Segovia.
Committed on 24/01/2023 at 03:26.
Pushed by lsegovia into branch 'master'.

python: Revert upgrade to 3.10 on Windows

Unfortunately, CI still relies on 3.8 for its virtualenv. Filed T16165
with sysadmin to confirm the version, and if an upgrade is possible.
CCMAIL:kimageshop@kde.org

M  +6    -8    3rdparty/ext_python/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/ed6d5e622f4376cc6888f4cc2bb5b397ef644e8c

Comment 4 amyspark 2023-01-24 18:24:50 UTC

Freya, sysadmin updated Python to 3.10 on Windows today morning. I've redeployed the upgrade, refreshed the nightly build, and now it loads 3.10 successfully. Let me know if you find any issues with the Python support!