| Summary: | [Wayland] Copying text once from GTK app is registered by clipboard applet but subsequent copying of text from the same GTK app is not registered | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Bacteria <dev.bacteriostat> |
| Component: | Clipboard | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | avelingker, bednarczyk.pawel, butirsky, m.orly97, nate, nerumo |
| Priority: | VHI | Keywords: | regression |
| Version: | 5.26.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/a7e5d1da87b0efaedd18ef5b0e1228824c91e922 | Version Fixed In: | 5.27 |
| Sentry Crash Report: | |||
| Attachments: | Video demonstrating the bug | ||
|
Description
Bacteria
2023-01-19 15:53:13 UTC
Can reproduce. This might address the issue but I don't use git version of plasma to test it out: https://invent.kde.org/plasma/kwin/-/merge_requests/3462 Git commit d6b75907cca668d0c2b226d44dcab4ebe55e3b6b by David Redondo. Committed on 24/01/2023 at 09:35. Pushed by davidre into branch 'master'. Data control: Resend selection when not following through with request Normal event flow is from a client view is -> wlr_data_control_device.set_selection wlr_data_control_device.selection or wlr_data_control_source.cancelled wlr_data_control_device.selection However when the race mentioned in the comment happens the client sees -> wlr_data_control_device.set_selection wlr_data_control_device.selection wlr_data_control_source_cancelled Which can confuse client state thinking the clipboard didn't change as it associates the selection event with its own request. Resend the selection event in this case to tell the client the correct selection. FIXED-IN:5.27 M +4 -0 src/wayland/seat_interface.cpp https://invent.kde.org/plasma/kwin/commit/d6b75907cca668d0c2b226d44dcab4ebe55e3b6b Git commit fc1b6ccfa561a07a215cbc64ca6cc4e3d35e3fdf by Vlad Zahorodnii, on behalf of David Redondo. Committed on 24/01/2023 at 10:34. Pushed by vladz into branch 'cherry-pick-d6b75907'. Data control: Resend selection when not following through with request Normal event flow is from a client view is -> wlr_data_control_device.set_selection wlr_data_control_device.selection or wlr_data_control_source.cancelled wlr_data_control_device.selection However when the race mentioned in the comment happens the client sees -> wlr_data_control_device.set_selection wlr_data_control_device.selection wlr_data_control_source_cancelled Which can confuse client state thinking the clipboard didn't change as it associates the selection event with its own request. Resend the selection event in this case to tell the client the correct selection. FIXED-IN:5.27 (cherry picked from commit d6b75907cca668d0c2b226d44dcab4ebe55e3b6b) M +4 -0 src/wayland/seat_interface.cpp https://invent.kde.org/plasma/kwin/commit/fc1b6ccfa561a07a215cbc64ca6cc4e3d35e3fdf Git commit a7e5d1da87b0efaedd18ef5b0e1228824c91e922 by David Redondo. Committed on 24/01/2023 at 10:58. Pushed by davidre into branch 'cherry-pick-d6b75907-2'. Data control: Resend selection when not following through with request Normal event flow is from a client view is -> wlr_data_control_device.set_selection wlr_data_control_device.selection or wlr_data_control_source.cancelled wlr_data_control_device.selection However when the race mentioned in the comment happens the client sees -> wlr_data_control_device.set_selection wlr_data_control_device.selection wlr_data_control_source_cancelled Which can confuse client state thinking the clipboard didn't change as it associates the selection event with its own request. Resend the selection event in this case to tell the client the correct selection. FIXED-IN:5.27 (cherry picked from commit d6b75907cca668d0c2b226d44dcab4ebe55e3b6b) M +4 -0 src/wayland/seat_interface.cpp https://invent.kde.org/plasma/kwin/commit/a7e5d1da87b0efaedd18ef5b0e1228824c91e922 *** Bug 464778 has been marked as a duplicate of this bug. *** |