Bug 464356

Summary:	Interacting with the calendar causes it to highlight the first day on the calendar when it gets opened again
Product:	[Plasma] plasmashell	Reporter:	guimarcalsilva
Component:	Digital Clock widget	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	nate, qydwhotmail, tantalising007
Priority:	NOR	Keywords:	regression
Version First Reported In:	5.26.90
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/commit/ba9bc2faab57e614304261e4eafca073fc11d9ca	Version Fixed/Implemented In:	5.27
Sentry Crash Report:
Attachments:	Wrong highlight

Description guimarcalsilva 2023-01-16 00:22:41 UTC

SUMMARY

Interacting with the calendar causes it to highlight the first day on the calendar when it gets opened again. I'm using Neon Unstable with the latest updates. 

Plasma 5.26.5 does not show this issue.

STEPS TO REPRODUCE
1. Click on the clock to open the calendar
2. Click on Today or switch tabs
3. Click on the clock again to close it
4. Click again to open the calendar

OBSERVED RESULT

The first day on the calendar is highlighted. Clicking on other days does not remove the buggy highlight either.

EXPECTED RESULT

It shouldn't highlight a day for no reason.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.26.80
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Kernel Version: 5.15.0-58-generic (64-bit)
Graphics Platform: Wayland
Processors: 6 × Intel® Core™ i5-9400F CPU @ 2.90GHz
Memory: 15,6 GiB of RAM
Graphics Processor: AMD Radeon RX 570 Series

ADDITIONAL INFORMATION:

This is a regression.

Comment 1 guimarcalsilva 2023-01-16 00:29:56 UTC

Created attachment 155333 [details]
Wrong highlight

Comment 2 Nate Graham 2023-01-17 21:00:30 UTC

Can confirm.

Comment 3 Bug Janitor Service 2023-01-28 09:32:53 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2555

Comment 4 Fushan Wen 2023-01-28 10:14:38 UTC

Git commit 64d8e131c8bfbd2ef901e4933e6c7fff6abf7e8f by Fushan Wen, on behalf of Tanbir Jishan.
Committed on 28/01/2023 at 10:14.
Pushed by fusionfuture into branch 'master'.

calendar: Fix highlight when opening calendar with year or decade tab last selected
FIXED-IN: 5.27

M  +0    -6    applets/digital-clock/package/contents/ui/CalendarView.qml
M  +0    -4    components/calendar/qml/MonthView.qml

https://invent.kde.org/plasma/plasma-workspace/commit/64d8e131c8bfbd2ef901e4933e6c7fff6abf7e8f

Comment 5 Fushan Wen 2023-01-28 10:27:01 UTC

Git commit 4b73d39bf2bbe34cc9ed8bc0ca859d982d4d2c8e by Fushan Wen, on behalf of Tanbir Jishan.
Committed on 28/01/2023 at 10:26.
Pushed by fusionfuture into branch 'cherry-pick-64d8e131'.

calendar: Fix highlight when opening calendar with year or decade tab last selected
FIXED-IN: 5.27


(cherry picked from commit 64d8e131c8bfbd2ef901e4933e6c7fff6abf7e8f)

M  +0    -6    applets/digital-clock/package/contents/ui/CalendarView.qml
M  +0    -4    components/calendar/qml/MonthView.qml

https://invent.kde.org/plasma/plasma-workspace/commit/4b73d39bf2bbe34cc9ed8bc0ca859d982d4d2c8e

Comment 6 Fushan Wen 2023-01-28 10:53:19 UTC

Git commit ba9bc2faab57e614304261e4eafca073fc11d9ca by Fushan Wen, on behalf of Tanbir Jishan.
Committed on 28/01/2023 at 10:53.
Pushed by fusionfuture into branch 'Plasma/5.27'.

calendar: Fix highlight when opening calendar with year or decade tab last selected
FIXED-IN: 5.27


(cherry picked from commit 64d8e131c8bfbd2ef901e4933e6c7fff6abf7e8f)

M  +0    -6    applets/digital-clock/package/contents/ui/CalendarView.qml
M  +0    -4    components/calendar/qml/MonthView.qml

https://invent.kde.org/plasma/plasma-workspace/commit/ba9bc2faab57e614304261e4eafca073fc11d9ca