Bug 464354

Summary:	When typing in the Face Tag Box whilst in "Preview", esc should just exit the type box
Product:	[Applications] digikam	Reporter:	Rebecca Wardle <beccamwardle>
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version First Reported In:	7.9.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/299cc394997976b3cb94b7070cd0f571708d95df	Version Fixed/Implemented In:	8.0.0
Sentry Crash Report:

Description Rebecca Wardle 2023-01-16 00:16:59 UTC

Experienced on Windows 11
This is a usability feature. 

When typing into the Face Tag Box whilst in "Preview" mode, esc should just exit the type box instead of exiting preview mode back to "Thumbnails" view. A second esc could then escape "Preview" mode, but I (and I suspect most users) would expect "Esc" to initially escape/exit any active text boxes before changing the display

Comment 1 Maik Qualmann 2023-01-16 07:02:00 UTC

I'm not entirely clear where the problem lies exactly. If the faces don't have a confirmed name yet, the input box is always present, that's by design. When there are multiple face rectangles, one input box always has focus. Do you want to close the tag suggestion box with the first ESC that opens after typing?

Maik

Comment 2 Rebecca Wardle 2023-01-16 07:39:24 UTC

I think there should be shortcut options for the buttons under the text box: "Ok", "Remove" and "Ignore". After typing a name into the box "Ok" can be triggered with enter and I think there should be keybinds so you don't have to use the mouse to click on "Remove" or "Ignore"

Comment 3 Maik Qualmann 2023-01-16 20:44:01 UTC

Git commit 299cc394997976b3cb94b7070cd0f571708d95df by Maik Qualmann.
Committed on 16/01/2023 at 20:43.
Pushed by mqualmann into branch 'master'.

close the suggestion box with Esc only on the first press
FIXED-IN: 8.0.0

M  +2    -1    NEWS
M  +6    -5    core/libs/tags/widgets/addtagscombobox.cpp
M  +0    -6    core/utilities/facemanagement/widgets/assignnamewidget.cpp

https://invent.kde.org/graphics/digikam/commit/299cc394997976b3cb94b7070cd0f571708d95df

Comment 4 caulier.gilles 2023-01-16 20:56:37 UTC

Git commit ef852d1bb7a80928753730764901313a4c51f10f by Gilles Caulier.
Committed on 16/01/2023 at 20:55.
Pushed by cgilles into branch 'master'.

add note in online doc about ESC key to leaves people tag editor in Preview mode

M  +1    -1    main_window/people_view.rst

https://invent.kde.org/documentation/digikam-doc/commit/ef852d1bb7a80928753730764901313a4c51f10f

Comment 5 Maik Qualmann 2023-01-16 21:20:51 UTC

Exactly explained again, if the completer is displayed after typing letters, it will be closed with ESC. If the completer is closed, ESC closes the preview and returns to the thumbnail view.

Maik