Bug 464252

Summary: The +1 Minute button doesn't do anything to the timer.
Product: [Applications] KClock Reporter: pawlowski486
Component: GeneralAssignee: Devin Lin <espidev>
Status: RESOLVED FIXED    
Severity: normal CC: hanyoung
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma-mobile/kclock/commit/8eaba7b58a75093199ab7d3532154cc2c35a65c6 Version Fixed/Implemented In: 23.01
Sentry Crash Report:

Description pawlowski486 2023-01-13 20:29:37 UTC 
SUMMARY
When in the detail view of a timer (where there's a big circle around the remaining time) there is a "+ 1 minute" button. The button doesn't do anything.

STEPS TO REPRODUCE
1. Start the timer. Press the [+ 1 minute] button.
2. Pause the timer. Press the [+ 1 minute] button.
3. Reset the timer. Press the [+ 1 minute] button.
4. Loop the timer. Press the [+ 1 minute] button.

OBSERVED RESULT
The timer is not affected by the [+ 1 minute] button. The remaining time will not change, and when the timer hits 0, it will ring. It will not wait an extra minute; not even an extra second!

EXPECTED RESULT
I expect a minute to be added to the remaining timer time. For example, if the timer has 10 seconds remaining and I press the [+ 1 minute] button, I expect to see 1 minute and 10 seconds remaining on the timer.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Kernel Version 5.15.85-1-MANJARO (64-bit)
(available in About System)
KDE Plasma Version: 5.26.4
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7
Graphics Platform: Wayland
App version: 22.11 Distributed by Flathub.

ADDITIONAL INFORMATION
Comment 1 Devin Lin 2023-01-14 06:45:42 UTC 
Git commit 8eaba7b58a75093199ab7d3532154cc2c35a65c6 by Devin Lin.
Committed on 14/01/2023 at 06:41.
Pushed by devinlin into branch 'master'.

Fix timer add one minute button
FIXED-IN: 23.01
Apparently got broken in some sort of refactoring...

M  +3    -1    src/kclock/qml/timer/TimerComponent.qml
M  +5    -1    src/kclock/qml/timer/TimerPage.qml

https://invent.kde.org/plasma-mobile/kclock/commit/8eaba7b58a75093199ab7d3532154cc2c35a65c6