Summary: | Pressing Ctrl+Shift+2 blocks spacebar panning and mouse right click | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | YRH <yavn.work> |
Component: | Shortcuts and Canvas Input Settings | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73, halla |
Priority: | NOR | ||
Version: | 5.1.5 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/33bd0de4122a5c1a766fb1cc13c4df8522833298 | Version Fixed In: | |
Sentry Crash Report: |
Description
YRH
2023-01-12 00:05:24 UTC
Does not happen on Linux (Ubuntu 20.04). Thank you for the report. I can reproduce it on Windows, though I have no idea whatsoever why this key combination breaks... Hi, YRH! Could you tell what keyboard layout you use? Is it something different from EN-US? If it is non-US layout, then I **can** reproduce the issue in master. Though I cannot reproduce that in EN-US layout. Hi, unfortunately, it doesn't seem to depend on the keyboard layout on my systems. I tested two Windows 11 installations, tried a few language and layout setups, two keyboard types (full and TKL), as well as another system with a fully fresh Krita 5.2.1 install, US display language, US region, and the only one US keyboard layout. At any time I press CTRL+SHIFT+2 while painting on canvas, middle mouse button (pan canvas) will stop working. Then I can get it back to work by left-clicking inside the layers docker. I didn't use any pen input at this time. Windows 11 versions were 22H2 and 23H2. I don't have a Windows 10 install at the moment. Hi, YRH! Are you sure you used EN-US layout for all these test? I cannot reproduce the issue, however hard I try. The issue happens only when I activate Russian layout. Even French layout doesn't break it :) This is the log when using RU-RU layout: The key-press for the '2' key arrives as Qt::Key_At and key-release arrives and Qt::Key_2, which blocks confuses the shortcuts matcher [9556] krita.tabletlog: "[ ] ShortcutOverride key: 0x1000021 mod: 0x4000000 text: none autorepeat: 0" [9556] keyPressed - Pressed keys: QSet(Qt::Key_Control) [9556] tryActivateReadyShortcut - Deactivated previous shortcut action act: "Tool Invocation" [9556] tryActivateReadyShortcut - Preparing new ready action act: "Alternate Invocation" [9556] krita.tabletlog: "[ ] ShortcutOverride key: 0x1000020 mod: 0x6000000 text: none autorepeat: 0" [9556] keyPressed - Pressed keys: QSet(Qt::Key_Shift, Qt::Key_Control) [9556] tryActivateReadyShortcut - Deactivated previous shortcut action act: "Alternate Invocation" [9556] tryActivateReadyShortcut - Preparing new ready action act: "Alternate Invocation" [9556] krita.tabletlog: "[ ] ShortcutOverride key: 0x40 mod: 0x6000000 text: 2 autorepeat: 0" [9556] keyPressed - Pressed keys: QSet(Qt::Key_Shift, Qt::Key_Control, Qt::Key_At) [9556] tryActivateReadyShortcut - Deactivated previous shortcut action act: "Alternate Invocation" [9556] tryActivateReadyShortcut - Preparing new ready action act: "Tool Invocation" [9556] krita.tabletlog: "[ ] KeyRelease key: 0x40 mod: 0x6000000 text: 2 autorepeat: 1" [9556] krita.tabletlog: "[ ] ShortcutOverride key: 0x40 mod: 0x6000000 text: 2 autorepeat: 1" # FAULTY KEY RELEASE [9556] krita.tabletlog: "[ ] KeyRelease key: 0x32 mod: 0x6000000 text: 2 autorepeat: 0" [9556] keyReleased - Peculiar, key released but can't remember it was pressed [9556] keyReleased - Released keys: QSet(Qt::Key_Shift, Qt::Key_Control, Qt::Key_At) [9556] krita.tabletlog: "[ ] KeyRelease key: 0x1000020 mod: 0x4000000 text: none autorepeat: 0" [9556] keyReleased - Released keys: QSet(Qt::Key_Control, Qt::Key_At) [9556] krita.tabletlog: "[ ] KeyRelease key: 0x1000021 mod: 0x0 text: none autorepeat: 0" [9556] keyReleased - Released keys: QSet(Qt::Key_At) [9556] krita.tabletlog: "[ ] ShortcutOverride key: 0x20 mod: 0x0 text: autorepeat: 0" [9556] keyPressed - Pressed keys: QSet(Qt::Key_Space, Qt::Key_At) [9556] krita.tabletlog: "[ ] KeyRelease key: 0x20 mod: 0x0 text: autorepeat: 1" [9556] krita.tabletlog: "[ ] ShortcutOverride key: 0x20 mod: 0x0 text: autorepeat: 1" [9556] krita.tabletlog: "[ ] KeyRelease key: 0x20 mod: 0x0 text: autorepeat: 1" [9556] krita.tabletlog: "[ ] ShortcutOverride key: 0x20 mod: 0x0 text: autorepeat: 1" [9556] krita.tabletlog: "[ ] KeyRelease key: 0x20 mod: 0x0 text: autorepeat: 1" Yes, I'm sure of it. I removed all other languages and keyboard layouts, only left English/US with US keyboard layout. It didn't matter. I have no idea why the behavior is inconsistent. Hi, YRH! Could you please check this package? I think I have fixed this issue, even though I don't know how it could happen without an extra layout present in the system... https://disk.yandex.ru/d/W8rcGcmyZqMrTg Hi Dmitry, CTRL+SHIFT+2 bug is fixed with your build. To be double sure, I checked master top of tree (f54e9e106e) and the bug still occurred there. So it looks like you have the fix, that's great! Git commit 44586919d56d98763ed04a8a3e9ddd3e8045d40f by Dmitry Kazakov. Committed on 15/11/2023 at 10:54. Pushed by dkazakov into branch 'master'. Fixes for Qt: MDI titles and unbalanced non-us shortcuts M +1 -1 3rdparty/ext_qt/CMakeLists.txt https://invent.kde.org/graphics/krita/-/commit/44586919d56d98763ed04a8a3e9ddd3e8045d40f Git commit 33bd0de4122a5c1a766fb1cc13c4df8522833298 by Dmitry Kazakov. Committed on 15/11/2023 at 10:55. Pushed by dkazakov into branch 'krita/5.2'. Fixes for Qt: MDI titles and unbalanced non-us shortcuts M +1 -1 3rdparty/ext_qt/CMakeLists.txt https://invent.kde.org/graphics/krita/-/commit/33bd0de4122a5c1a766fb1cc13c4df8522833298 |