| Summary: | PCX image issues | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kimageformats | Reporter: | fenugrec |
| Component: | general | Assignee: | Alex Merry <alex.merry> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, kdelibs-bugs-null, mircomir, nate, tsujan2000 |
| Priority: | NOR | ||
| Version First Reported In: | 5.101.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kimageformats/-/commit/bb66367bc82bd656150792da6eef1076f0cf69b5 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | test PCX image that fails with kimageformats, but is correctly opened by gimp | ||
I'm not sure why my initial comment doesn't show up on the summary page here ? Pasting again just in case, sorry if it's duplicate : *********** SUMMARY Loading certain pcx files , via a generic image viewer (lximage-qt), produces a black rectangle . The same file can be correctly opened in any recent version of gimp. Not sure how else to reproduce or troubleshoot this except via general software that uses QImageReader as a backend. STEPS TO REPRODUCE 1. try any software that uses QImageReader 2. load attached .pcx file OBSERVED RESULT black rectangle of the correct size. EXPECTED RESULT Correct grayscale image KDE's GWenview has the same behavior. The problem is independent of the Qt viewer (I tried 3). Mirco would you have interest in looking into what may be wrong here? (In reply to Albert Astals Cid from comment #3) > Mirco would you have interest in looking into what may be wrong here? Yes, I'll take a look at it. (In reply to fenugrec from comment #0) > Created attachment 155083 [details] > test PCX image that fails with kimageformats, but is correctly opened by gimp We have a fix for your bug report. Can we use this image in ours test case? It's free of any copyrights? (In reply to Mirco Miranda from comment #5) > We have a fix for your bug report. Can we use this image in ours test case? > It's free of any copyrights? Already ! that was fast, thanks. Yes, you may use the image without restriction. Git commit 14742cb502272b8029103ce10148dfe5d0317e80 by Albert Astals Cid, on behalf of Mirco Miranda. Committed on 11/01/2023 at 22:56. Pushed by aacid into branch 'master'. PCX: Fix reading of the extended palette The VGA palette starts 769 bytes before the end of the file. There may be PADs between the end of the image and the start of the palette. A +- -- autotests/read/pcx/ccbug_463951.pcx A +- -- autotests/read/pcx/ccbug_463951.png M +14 -3 src/imageformats/pcx.cpp https://invent.kde.org/frameworks/kimageformats/commit/14742cb502272b8029103ce10148dfe5d0317e80 Git commit bb66367bc82bd656150792da6eef1076f0cf69b5 by Albert Astals Cid, on behalf of Mirco Miranda. Committed on 25/05/2023 at 21:58. Pushed by aacid into branch 'kf5'. PCX: Fix reading of the extended palette The VGA palette starts 769 bytes before the end of the file. There may be PADs between the end of the image and the start of the palette. (cherry picked from commit 14742cb502272b8029103ce10148dfe5d0317e80) A +- -- autotests/read/pcx/ccbug_463951.pcx A +- -- autotests/read/pcx/ccbug_463951.png M +14 -3 src/imageformats/pcx.cpp https://invent.kde.org/frameworks/kimageformats/-/commit/bb66367bc82bd656150792da6eef1076f0cf69b5 |
Created attachment 155083 [details] test PCX image that fails with kimageformats, but is correctly opened by gimp SUMMARY Loading certain pcx files , via a generic image viewer (lximage-qt), produces a black rectangle . The same file can be correctly opened in any recent version of gimp. Not sure how else to reproduce or troubleshoot this except via general software that uses QImageReader as a backend. STEPS TO REPRODUCE 1. try any software that uses QImageReader 2. load attached .pcx file OBSERVED RESULT black rectangle of the correct size. EXPECTED RESULT Correct grayscale image