Bug 463937

Summary:	The ‘Find numerator/denominator’ fractions levels are confusing numerators with denominators
Product:	[Applications] gcompris	Reporter:	Karl Ove Hufthammer <karl>
Component:	general	Assignee:	Jazeix Johnny <jazeix>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/education/gcompris/commit/dc4c33189657afc463469ee96c2da2046e338a2d	Version Fixed/Implemented In:
Sentry Crash Report:

Description Karl Ove Hufthammer 2023-01-06 19:40:15 UTC

SUMMARY
The wording is wrong in the ‘Find numerator’ and ‘Find denominator’ level names. In the ‘Find numerator’ levels, you are asked to find a denominator, and in the ‘Find denominator’ levels, you are asked to find a numerator.

STEPS TO REPRODUCE
1. Open the ‘Find fractions’ activity.
2. Open the level selector.
3. Select only ‘Find numerator’ levels (or only ‘Find denominator’ levels).

OBSERVED RESULT
You are asked to select a denominator.
(The opposite is true of you select a denominator level.)

EXPECTED RESULT
You should be asked to select a numerator.
(Or a denominator, if you selected a denominator level.)

Comment 1 Jazeix Johnny 2023-01-06 20:25:37 UTC

Git commit be2a450c982b9920fc3cff2c40a7bd04ba67c8ef by Johnny Jazeix.
Committed on 06/01/2023 at 20:24.
Pushed by jjazeix into branch 'master'.

fractions_find, fix datasets instructions.
They were reversed, and on levels to find the numerator, the instruction said to find the denominator. And vice versa.

M  +1    -1    src/activities/fractions_find/resource/1/Data.qml
M  +1    -1    src/activities/fractions_find/resource/2/Data.qml
M  +1    -1    src/activities/fractions_find/resource/3/Data.qml
M  +1    -1    src/activities/fractions_find/resource/4/Data.qml

https://invent.kde.org/education/gcompris/commit/be2a450c982b9920fc3cff2c40a7bd04ba67c8ef

Comment 2 Jazeix Johnny 2023-01-06 20:26:31 UTC

Thank you for testing and reporting these issues, we'll ask for a string freeze break to apply them on the release!

Comment 3 Jazeix Johnny 2023-01-08 10:15:54 UTC

Git commit dc4c33189657afc463469ee96c2da2046e338a2d by Johnny Jazeix.
Committed on 08/01/2023 at 10:12.
Pushed by jjazeix into branch 'KDE/3.0'.

fractions_find, fix datasets instructions.
They were reversed, and on levels to find the numerator, the instruction said to find the denominator. And vice versa.

M  +1    -1    src/activities/fractions_find/resource/1/Data.qml
M  +1    -1    src/activities/fractions_find/resource/2/Data.qml
M  +1    -1    src/activities/fractions_find/resource/3/Data.qml
M  +1    -1    src/activities/fractions_find/resource/4/Data.qml

https://invent.kde.org/education/gcompris/commit/dc4c33189657afc463469ee96c2da2046e338a2d