| Summary: | All images are getting correlated although w/o considering selection | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | fuerallesg |
| Component: | Geolocation-Correlator | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version First Reported In: | 7.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/digikam/commit/b1e2043996ef6357ccf2696c58d51d0818210835 | Version Fixed/Implemented In: | 8.0.0 |
| Sentry Crash Report: | |||
|
Description
fuerallesg
2023-01-03 18:20:08 UTC
Personally I think we should just fix the Doc. It makes no sense for me to only correlate selected ones. You can select before opening the geolocation editor. The correlator gives the possibility to provide all images with correct coordinates based on a GPX track list, why should you exclude some of them? This would probably also lead to confusion for long-time users. Gilles, what are you thinking? Change Doc or apply only selected items. Maik I'm not sure to understand (:=))) Historically, you can select from icon-view the items to process. This is how the plugin interface is implemented. When items are loaded in plugins they must appears as well. You can adjust the list of items (remove or append). The list shown in plugin, and only this one will be processed. After all the GUI must be logic to use. So where the problem exactly ? Which part of the doc must be corrected if necessary ? Gilles It's about the image list in the Geolocation Editor, here no more images can be removed or added later. The GPX Correlator uses all the images in the list. The user request here is that only selected images from the image list are used by the GPX correlator. I haven't looked at the relevant part of the Doc yet. Maik I try to explain it again: I select some images in digikam and start the Geolocation tool. The selected images are now shown in a list (below the map) in which I can select images again. My understanding of the documention is that selected images in the geolocation tool are processed in the correlation process but all are processed without considering selected images. However, if I understand you that is the correct behavior. You mention that I can add and remove images from the list in the Geolocation tool-how can I do this? As long as the Geolocation tool window ist open no mouse clicks are considered from the main digikam window. @Maik: That's the way I understand it. However, maybe I have misunderstood the documentation Based on my workflow (which should not be the reference for all) it makes sense to have the option to select specific images. Usually, I import all my images into the Geolocation tool from one session to proof the coordinates and set location keywords. Especially, mobile phone pictures have sometimes some deviation from the correct location so that I like to correct them but keep the others unchanged. Afterward, I use the reverse referencing to set my keywords. Maybe an alternative to not confuse other users with changes, it would be great having the option to go back to the original (if existing) coordinations by the context menu as long the data is not saved I see. I don't know why the Geolocation Editor do not have the list management button to adjust contents. I can be simple to add and customize (typically an option to set in list widget). This will solve the problem ? Gilles Well no. the list view from Geolocation Editor do not use the common list widget used by all plugins. Why ? i don't remember. So to append management buttons for the list is less simple than expected... Gilles No, add and remove buttons would not improve it. You would then first have to remove all images that should not be correlated. We can't easily add images either, under digiKam we have GPS Items which has been overloaded with database GPS Items. Maik About the doc, Geolocation Editor has a dedicated section here: https://docs.digikam.org/en/geolocation_editor.html I don't yet fully review all parts from this section... Gilles So the Doc is correct. It is written select the images you want to correlate in the *main application* and call up the Geolocation Editor. It does not say that the images must be selected in the image list. Maik You are right. My fault, sorry. Maybe I have read an unofficial documentation about the usage of the tool and that in mind. As a 'new' user it is not so intuitive if you can select images in the tool directly but without any impact. However, I can understand if you want to keep it for existing users unchanged. Therefore, my feature suggestion to have the option to back to the values at the time of starting the tool by the conext menu based on a image selection. (In reply to fuerallesg from comment #10) > You are right. My fault, sorry. Maybe I have read an unofficial > documentation about the usage of the tool and that in mind. > > As a 'new' user it is not so intuitive if you can select images in the tool > directly but without any impact. However, I can understand if you want to > keep it for existing users unchanged. > > Therefore, my feature suggestion to have the option to back to the values at > the time of starting the tool by the conext menu based on a image selection. Short addon: Reverse referencing works like expected. Here you can select specific images. For a newbie a bit confusing that the different tabs work different ;) Git commit b1e2043996ef6357ccf2696c58d51d0818210835 by Maik Qualmann. Committed on 07/01/2023 at 18:56. Pushed by mqualmann into branch 'master'. add option to correlate selected images only FIXED-IN: 8.0.0 M +2 -1 NEWS M +1 -1 core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.cpp M +37 -11 core/utilities/geolocation/geoiface/correlator/gpscorrelatorwidget.cpp M +2 -0 core/utilities/geolocation/geoiface/correlator/gpscorrelatorwidget.h https://invent.kde.org/graphics/digikam/commit/b1e2043996ef6357ccf2696c58d51d0818210835 |