Bug 463699

Summary: KApplication is gone, but still mentioned in the README file
Product: [Frameworks and Libraries] frameworks-kinit Reporter: Christopher Yeleighton <giecrilj>
Component: generalAssignee: David Faure <faure>
Status: RESOLVED FIXED    
Severity: normal CC: christoph, kdelibs-bugs-null, nate
Priority: NOR    
Version First Reported In: 5.101.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
URL: file:///usr/share/doc/packages/kinit/README.md
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Christopher Yeleighton 2023-01-01 16:40:25 UTC 
SUMMARY
KApplication does not exist any more, so mentioning it is WTF.

STEPS TO REPRODUCE
1. Read the document README.md!

OBSERVED RESULT
(application without KApplication constructor, the KApplication constructor requires an extra 100ms in both cases) 

EXPECTED RESULT
(application without QApplication constructor, the QApplication constructor requires an extra 100ms in both cases) 

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: openSUSE Tumbleweed 20221230
(available in About System)
KDE Plasma Version: 5.26.4
KDE Frameworks Version: 5.26.4
Qt Version: 5.15.7

ADDITIONAL INFORMATION
<URL: https://community.kde.org/Frameworks/Porting_Notes#Application >
Comment 1 Nate Graham 2023-01-06 21:45:19 UTC 
> mentioning it is WTF
This isn't how we communicate in KDE. Please tone down the language.

Since this is just an issue in a README file, maybe you can submit a merge request to fix it? Should be easy.
Comment 2 Christopher Yeleighton 2023-01-07 09:13:33 UTC 
Thanks for the encouragement.  The reason why I did not just do it is that it refers to a performance measurement that was run a long ago on hardware that can safely be described as ancient, so just fixing the class name seems to be misleading at best.  Do you really want to keep the old text?
Comment 3 Nate Graham 2023-01-07 13:52:39 UTC 
Well the performance benefits of a thing that's been removed aren't relevant anymore to today's reality, right?

I'd recommend opening a merge request and CCing David Edmundson (@davidedmundson) and Albert Astals Cid (@aacid) as they're more familiar with the details of the change itself.
Comment 4 Christopher Yeleighton 2023-01-07 20:29:23 UTC 
The comment was about start-up PENALTY of using KApplication.  Including such information about QApplication feels inappropriate because it is not our class.
Comment 5 Christoph Cullmann 2023-07-03 21:39:12 UTC 
Fixed in master by removing kinit.