| Summary: | WindowHeap-based effects show windows with "Skip Pager" or "Skip Switcher" flags | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | D. Debnath <d_debnath> |
| Component: | effects-window-management | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ad.liu.jin, jjaruszewski, kde, nate, nicolas.fella, notmart, postix |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.26.4 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/b43052af83d9c6f14f8f88b99f6186e3e66b4df5 | Version Fixed In: | 6.0 |
| Sentry Crash Report: | |||
| Attachments: |
Konsole window (pinned to all desktops) shown in the Desktop Grid effect
Window rules applied to Konsole window |
||
|
Description
D. Debnath
2022-12-28 05:25:01 UTC
Yeah, the new ones should do this too. I cannot reproduce any issue with any known windows using these flags. Please confirm if it is still an issue and the application window was incorrectly displayed Created attachment 155694 [details] Konsole window (pinned to all desktops) shown in the Desktop Grid effect (In reply to David Edmundson from comment #2) > Please confirm if it is still an issue and the application window was > incorrectly displayed Yes, I can confirm that this is still an issue. Created attachment 155695 [details]
Window rules applied to Konsole window
(In reply to David Edmundson from comment #2) > I cannot reproduce any issue with any known windows using these flags. > Please confirm if it is still an issue and the application window was > incorrectly displayed I guess most of our windows with these flags also have a special type that results in them being filtered out, like NET:Dock. https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2583 uses NET::Normal + SkipSwitcher and there the window still shows up in the effects Apparently ClientModel v3 only allows filtering by window type, not by Skip* flags. ClientModel v2 does allow that I want to clarify that the new implementations of the effects *do* respect the "Skip Pager" and "Skip Switcher" window rules. However, the previous implementations of the "Present Windows" and "Desktop Grid" effects additionally used to skip showing the windows based on one of these window rules (skip pager/switcher), but the new effects *don't*. As a solution, I hope a new window rule can be introduced, namely: "Skip Present Windows/Desktop Grid/Overview" Actually I don't remember correctly what caused the windows to be skipped in the Present Windows / Desktop Grid effects. * Either there used to be window rules named "Skip Desktop Grid" / "Skip Present Windows" which were removed when the window rules were refactored. * Or the earlier implementations of "Desktop Grid" / "Present Windows" used to pick up the currently available "Skip Switcher" / "Skip Pager" window rules, but the new implementations no longer do. *** This bug has been marked as a duplicate of bug 478645 *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4826 Git commit b43052af83d9c6f14f8f88b99f6186e3e66b4df5 by Nate Graham, on behalf of Akseli Lahtinen. Committed on 21/12/2023 at 17:48. Pushed by ngraham into branch 'master'. WindowHeapDelegate: If window is set to "skip switcher", skip it from window heap Without this, windows like xwaylandvideobridge would show up. FIXED-IN: 6.0 M +3 -1 src/plugins/private/qml/WindowHeapDelegate.qml https://invent.kde.org/plasma/kwin/-/commit/b43052af83d9c6f14f8f88b99f6186e3e66b4df5 *** Bug 478645 has been marked as a duplicate of this bug. *** *** Bug 477625 has been marked as a duplicate of this bug. *** *** Bug 478747 has been marked as a duplicate of this bug. *** |