Bug 463541

Summary: Fail on building window.cpp.o, when executing ninja, while building kactivities
Product: [Frameworks and Libraries] plasma-activities Reporter: Greg <geebkk>
Component: generalAssignee: Ivan Čukić <ivan.cukic>
Status: CONFIRMED ---    
Severity: normal CC: nicolas.fella, plasma-bugs-null, yurii.kolesnykov
Priority: NOR    
Version First Reported In: 5.101.0   
Target Milestone: ---   
Platform: unspecified   
OS: macOS   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Greg 2022-12-28 02:08:10 UTC 
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
--Mac Mini 2018
--MacOS Ventura 13.1
--CRAFT from KDE

STEPS TO REPRODUCE
1.  Using CRAFT to build kde (ultimately, want to install Kile)
2.  In Craft:  craft kactivities
3. 

OBSERVED RESULT
[37/49] Building CXX object tests/activities-model/CMakeFiles/KActivitiesModelTestApp.dir/window.cpp.o
FAILED: tests/activities-model/CMakeFiles/KActivitiesModelTestApp.dir/window.cpp.o 

Error Message 'KX11Extras' file not found:
/Volumes/userslocal/greg/CraftRoot/build/kde/frameworks/tier2/kactivities/work/kactivities-5.101.0/tests/activities-model/window.cpp:14:10: fatal error: 'KX11Extras' file not found

Build error message:
ninja: build stopped: subcommand failed.
Action: compile for kde/frameworks/tier2/kactivities:5.101.0 FAILED
*** Craft all failed: kde/frameworks/tier2/kactivities after 34 seconds ***
fatal error: package kde/frameworks/tier2/kactivities all failed
Craft stopped with out completing ['kde/frameworks/tier2/kactivities']

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS:  Ventura 13.1
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
CRAFT info:

CRAFT:craft -i craft
Craft               : /Volumes/userslocal/greg/CraftRoot
Version             : master
ABI                 : macos-clang-x86_64
Comment 1 Yurii Kolesnykov 2022-12-28 22:30:07 UTC 
Regression was introduced by commit 5b270191 [0], which makes test to use new KWindowSystem's KX11Extras class [1] that is obviously shipped only on platforms with X11.

Luckily this issue only affects test, but not framework itself, so in Homebrew-KDE we just temporary disable test by a cmake option "-DBUILD_TESTING=OFF".

[0] https://invent.kde.org/frameworks/kactivities/-/commit/b1faa708be283b89c296f5e49f376396fe1b75d7
[1] https://invent.kde.org/frameworks/kwindowsystem/-/blob/master/src/kx11extras.h
Comment 2 Nicolas Fella 2022-12-28 23:13:37 UTC 
kactivities conceptually doesn't make sense on macOS since it's modelling a Plasma-only feature. We shoudln't bother with building it for macOS.

https://invent.kde.org/packaging/craft-blueprints-kde/-/merge_requests/442 adjusts the craft blueprints accordingly