Bug 463512

Summary:	"In Sidebar" Tooggle in Appearances Settings not effective
Product:	[Applications] NeoChat	Reporter:	Justin Zobel <justin.zobel>
Component:	General	Assignee:	Tobias Fella <fella>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, james.h.graham
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	https://invent.kde.org/network/neochat/commit/67f88416f1a448f291d3513d4e7d47feb837f084	Version Fixed/Implemented In:
Sentry Crash Report:

Description Justin Zobel 2022-12-27 09:11:11 UTC

22.11
Toggling In Sidebar doesn't affect Avatars being shown
Toggling In Chat toggles for Chat and Sidebar

Gary Wang in Neochat room confirmed same issue on master and mentioned showAvatarInRoomDrawer config option is unused.

Comment 1 James Graham 2022-12-27 10:00:34 UTC

Can confirm this is busted.

Comment 2 Bug Janitor Service 2022-12-27 10:06:50 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/725

Comment 3 Gary Wang 2022-12-27 10:33:28 UTC

Git commit 67f88416f1a448f291d3513d4e7d47feb837f084 by Gary Wang.
Committed on 27/12/2022 at 10:13.
Pushed by nvrwhere into branch 'master'.

Use the correct config option for 'In sidebar'

M  +1    -1    src/qml/Page/RoomListPage.qml

https://invent.kde.org/network/neochat/commit/67f88416f1a448f291d3513d4e7d47feb837f084