Bug 463438

Summary: SRU data source is limited to http protocol
Product: [Applications] tellico Reporter: Robby Stephenson <robby>
Component: generalAssignee: Robby Stephenson <robby>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 3.4.4   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 3.4.6
Sentry Crash Report:

Description Robby Stephenson 2022-12-24 17:46:33 UTC
SRU data source hard-codes a link using http protocol. https should be an option or fallback.

https://forum.kde.org/viewtopic.php?f=200&t=176792&sid=f1bb6ed0e806d8f77a4fabc8f13c1996
Comment 1 Robby Stephenson 2023-01-02 16:36:12 UTC
Git commit 9ae808ac1377e8f22bb417678fa277e89ea2b849 by Robby Stephenson.
Committed on 02/01/2023 at 16:34.
Pushed by rstephenson into branch '3.4'.

SRU fetcher should fallback to https if http returns invalid result

This being the stable branch, don't add a new config option to specify
protocol. Check for https in the returned string, as DNB does, and just
try again. Test case also added.
FIXED-IN: 3.4.6

M  +16   -3    src/fetch/srufetcher.cpp
M  +2    -0    src/fetch/srufetcher.h
M  +24   -0    src/tests/srufetchertest.cpp
M  +1    -0    src/tests/srufetchertest.h

https://invent.kde.org/office/tellico/commit/9ae808ac1377e8f22bb417678fa277e89ea2b849
Comment 2 Robby Stephenson 2023-01-02 16:59:55 UTC
Git commit a61580941cb931fd38763f0b832ca27abffeb276 by Robby Stephenson.
Committed on 02/01/2023 at 16:59.
Pushed by rstephenson into branch 'master'.

Add user option to define URL scheme for SRU data source

M  +24   -5    src/fetch/srufetcher.cpp
M  +3    -0    src/fetch/srufetcher.h
M  +25   -0    src/tests/srufetchertest.cpp
M  +1    -0    src/tests/srufetchertest.h

https://invent.kde.org/office/tellico/commit/a61580941cb931fd38763f0b832ca27abffeb276