| Summary: | Red eyes correction on windows 10 not functionning | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Bob06 <rofrdi06> |
| Component: | Faces-RedEyes | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version: | 7.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/digikam/commit/d81b9f3fb753cf5830d99fe66fffd3bcc99b4e97 | Version Fixed In: | 7.10.0 |
| Sentry Crash Report: | |||
| Attachments: |
before and after red eyes correction on windows 10
original file corrected file with red-eyes windows 10 |
||
Can you share the image not corrected to try to reproduce the problem here ? Gilles Caulier Created attachment 154760 [details]
original file
Created attachment 154761 [details]
corrected file with red-eyes windows 10
That's strange, it doesn't work for me either in AppImage-7.9.0 or in the current developer version, the result is like Windows 10. If you set a very low value, you can see that the correction seems to be in the hairs of the young man is applied. The location and distance indicate that the position is not correct. Maik Git commit d81b9f3fb753cf5830d99fe66fffd3bcc99b4e97 by Maik Qualmann. Committed on 23/12/2022 at 07:18. Pushed by mqualmann into branch 'qt5-maintenance'. use standard face detection model in the first step for finding faces in Red-Eye Correction. FIXED-IN: 7.10.0 M +2 -1 NEWS M +18 -10 core/libs/dimg/filters/redeye/redeyecorrectionfilter.cpp https://invent.kde.org/graphics/digikam/commit/d81b9f3fb753cf5830d99fe66fffd3bcc99b4e97 (In reply to Maik Qualmann from comment #5) > Git commit d81b9f3fb753cf5830d99fe66fffd3bcc99b4e97 by Maik Qualmann. > Committed on 23/12/2022 at 07:18. > Pushed by mqualmann into branch 'qt5-maintenance'. > > use standard face detection model > in the first step for finding faces in Red-Eye Correction. > FIXED-IN: 7.10.0 > > M +2 -1 NEWS > M +18 -10 core/libs/dimg/filters/redeye/redeyecorrectionfilter.cpp > > https://invent.kde.org/graphics/digikam/commit/ > d81b9f3fb753cf5830d99fe66fffd3bcc99b4e97 Hello I have downloaded 7.10.0 and the problem is not fixed. Only a part of the eyes is correct. Tested on Windows10 with digiKam-7.10.0-20230103T193317-Win64.exe and the sample image from here. The red eyes are completely corrected. I can't reproduce any problem. Maik (In reply to Maik Qualmann from comment #7) > Tested on Windows10 with digiKam-7.10.0-20230103T193317-Win64.exe and the > sample image from here. The red eyes are completely corrected. I can't > reproduce any problem. > > Maik I apologize, I have not download the good date of compilation. With digiKam-7.10.0-20230103T193317-Win64.exe it's OK Thanks Bob Git commit d198300bf06951b9a03951af44912525f28a5165 by Maik Qualmann. Committed on 19/10/2023 at 08:28. Pushed by mqualmann into branch 'master'. use YoloV3 face detection again for better red eye detection Adjust the size of detected faces for problematic images that didn't work with YoloV3. Related: bug 384614 M +12 -10 core/libs/dimg/filters/redeye/redeyecorrectionfilter.cpp https://invent.kde.org/graphics/digikam/-/commit/d198300bf06951b9a03951af44912525f28a5165 |
Created attachment 154759 [details] before and after red eyes correction on windows 10 OBSERVED RESULT after a very long time (34 sec) you obtain an half correction on windows 10. The correction works fine (normal speed ) on ubuntu 16.04 with the same version 7.9.0 See file attached SOFTWARE/OS VERSIONS Windows: 10